New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing double quotes #3404

Merged

javierm merged 4 commits into master from double_quotes

Mar 27, 2019

Member

javierm commented Mar 25, 2019

References

Pull request Change single quotes to double quotes everywhere #3370

Objectives

For consistency use double quotes everywhere we can.


          Add missing double quotes

2b4e1cf

We overlooked a few single quotes while we changed thousands of them.

houndci-bot reviewed

View reviewed changes

app/views/shared/_social_media_meta_tags.html.erb

    
              <meta id="ogimage" property="og:image" content="<%= root_url + (local_assigns[:og_image_url] || 'social_media_icon.png') %>"/>

              <meta property="og:site_name" content="<%= setting['org_name'] %>"/>

              <meta id="ogimage" property="og:image" content="<%= root_url + (local_assigns[:og_image_url] || "social_media_icon.png") %>"/>

              <meta property="og:site_name" content="<%= setting["org_name"] %>"/>

houndci-bot Mar 25, 2019

No space detected where there should be a single space.

app/views/shared/_social_media_meta_tags.html.erb

    
              <% end %>

              <meta property="og:type" content="article"/>

              <meta id="ogurl" property="og:url" content="<%= social_url %>"/>

              <meta id="ogimage" property="og:image" content="<%= root_url + (local_assigns[:og_image_url] || 'social_media_icon.png') %>"/>

              <meta property="og:site_name" content="<%= setting['org_name'] %>"/>

              <meta id="ogimage" property="og:image" content="<%= root_url + (local_assigns[:og_image_url] || "social_media_icon.png") %>"/>

houndci-bot Mar 25, 2019

No space detected where there should be a single space.

app/views/shared/_social_media_meta_tags.html.erb

    
              <% end %>

              <% if setting["facebook_handle"] %>

                <meta property="article:author" content="https://www.facebook.com/<%= setting['facebook_handle'] %>"/>

                <meta property="article:author" content="https://www.facebook.com/<%= setting["facebook_handle"] %>"/>

houndci-bot Mar 25, 2019

No space detected where there should be a single space.

app/views/shared/_social_media_meta_tags.html.erb

    
              <% if setting["url"] %>

                <meta property="article:publisher" content="<%= setting['url'] %>"/>

                <meta property="article:publisher" content="<%= setting["url"] %>"/>

houndci-bot Mar 25, 2019

No space detected where there should be a single space.

app/views/shared/_social_media_meta_tags.html.erb

    
              <!-- Facebook OG -->

              <meta id="ogtitle" property="og:title" content="<%= local_assigns[:social_title] || setting['meta_title'] %>"/>

              <meta id="ogtitle" property="og:title" content="<%= local_assigns[:social_title] || setting["meta_title"] %>"/>

houndci-bot Mar 25, 2019

No space detected where there should be a single space.

spec/features/management/budget_investments_spec.rb

    
                    mid_investment = create(:budget_investment, budget: @budget, title: 'Change district 9', heading: district_9, cached_votes_up: 10)

                    top_investment = create(:budget_investment, budget: @budget, title: 'Destroy district 9', heading: district_9, cached_votes_up: 100)

                    unvoted_investment = create(:budget_investment, budget: @budget, heading: another_heading, title: 'Add new districts to the city')

                    low_investment = create(:budget_investment, budget: @budget, title: "Nuke district 9", heading: district_9, cached_votes_up: 1)

houndci-bot Mar 25, 2019

Metrics/LineLength: Line is too long. [133/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

spec/features/budgets/investments_spec.rb

    
                    heading2 = create(:budget_heading, name: 'Barajas',     group: group)

                    group = create(:budget_group, name: "Districts", budget: budget)

                    heading1 = create(:budget_heading, name: "Carabanchel", group: group)

                    heading2 = create(:budget_heading, name: "Barajas",     group: group)

houndci-bot Mar 25, 2019

Lint/UselessAssignment: Useless assignment to variable - heading2. Did you mean heading1? (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)

spec/features/budgets/investments_spec.rb

    
                    low_investment.update_column(:confidence_score, 5)

                    high_investment = create(:budget_investment, :selected, heading: heading, title: 'Build a skyscraper', price: 20000)

                    high_investment = create(:budget_investment, :selected, heading: heading, title: "Build a skyscraper", price: 20000)

houndci-bot Mar 25, 2019

Metrics/LineLength: Line is too long. [122/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

spec/features/budgets/investments_spec.rb

    
                    mid_investment.update_column(:confidence_score, 10)

                    low_investment = create(:budget_investment, :selected, heading: heading, title: 'Build an ugly house', price: 1000)

                    low_investment = create(:budget_investment, :selected, heading: heading, title: "Build an ugly house", price: 1000)

houndci-bot Mar 25, 2019

Metrics/LineLength: Line is too long. [121/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

spec/features/budgets/investments_spec.rb

    
                  scenario 'Order by cost (only when balloting)' do

                    mid_investment = create(:budget_investment, :selected, heading: heading, title: 'Build a nice house', price: 1000)

                  scenario "Order by cost (only when balloting)" do

                    mid_investment = create(:budget_investment, :selected, heading: heading, title: "Build a nice house", price: 1000)

houndci-bot Mar 25, 2019

Metrics/LineLength: Line is too long. [120/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot reviewed

View reviewed changes

spec/features/budgets/investments_spec.rb

    
            @@ -1237,7 +1237,7 @@ def investments_order
          
                                      budget: budget,

                                      group: group,

                                      heading: heading,

                                      unfeasibility_explanation: 'Local government is not competent in this matter')

                                      unfeasibility_explanation: "Local government is not competent in this matter")

houndci-bot Mar 25, 2019

Metrics/LineLength: Line is too long. [102/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

spec/features/budgets/investments_spec.rb

    
            @@ -1219,7 +1219,7 @@ def investments_order
          
                                      budget: budget,

                                      group: group,

                                      heading: heading,

                                      unfeasibility_explanation: 'Local government is not competent in this matter')

                                      unfeasibility_explanation: "Local government is not competent in this matter")

houndci-bot Mar 25, 2019

Metrics/LineLength: Line is too long. [102/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

spec/features/budgets/investments_spec.rb

    
                    check   'budget_investment_terms_of_service'

                    select  heading.name, from: "budget_investment_heading_id"

                    fill_in "budget_investment_title", with: "Build a skyscraper"

                    fill_in "budget_investment_description", with: "I want to live in a high tower over the clouds"

houndci-bot Mar 25, 2019

Metrics/LineLength: Line is too long. [101/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

spec/features/budgets/investments_spec.rb

    
                      expect(page).to have_content "You're on page 1"

                      expect(investments_order).to eq(@second_user_investments_order)

                    end

                  end

                  scenario 'Each user has a equal and consistent budget investment order when the random_seed is equal' do

                  scenario "Each user has a equal and consistent budget investment order when the random_seed is equal" do

houndci-bot Mar 25, 2019

Metrics/LineLength: Line is too long. [108/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

spec/features/budgets/investments_spec.rb

    
                    heading2 = create(:budget_heading, name: 'Barajas',     group: group)

                    group = create(:budget_group, name: "Districts", budget: budget)

                    heading1 = create(:budget_heading, name: "Carabanchel", group: group)

                    heading2 = create(:budget_heading, name: "Barajas",     group: group)

houndci-bot Mar 25, 2019

Lint/UselessAssignment: Useless assignment to variable - heading2. Did you mean heading1? (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)

app/views/valuation/budget_investments/edit.html.erb

    
            @@ -1,6 +1,6 @@
          
              <%= link_to valuation_budget_budget_investment_path(@budget, @investment), class: "back" do %>

                <span class="icon-angle-left"></span>

                <%= "#{t('valuation.budget_investments.show.title')} #{@investment.id}"%>

                <%= "#{t("valuation.budget_investments.show.title")} #{@investment.id}"%>

houndci-bot Mar 25, 2019

Use 1 space before %> instead of 0 space.

app/views/management/user_invites/new.html.erb

    
            @@ -7,6 +7,6 @@
          
                                  placeholder: t("management.user_invites.new.info"),

                                  aria: {describedby: "emails-help-text"} %>

                <div class="small-12 medium-6 large-3">

                  <input type="submit" name="" value="<%= t('management.user_invites.new.submit') %>", class="button expanded">

                  <input type="submit" name="" value="<%= t("management.user_invites.new.submit") %>", class="button expanded">

houndci-bot Mar 25, 2019

Non-whitespace character(s) detected: ",".

app/views/admin/poll/officers/user_not_found.js.erb

    
            @@ -1 +1 @@
          
              $("#search-result").html("<div class=\"callout alert\"><%= j t('admin.poll_officers.search.user_not_found') %></div>");

              $("#search-result").html("<div class=\"callout alert\"><%= j t("admin.poll_officers.search.user_not_found") %></div>");

houndci-bot Mar 25, 2019

Extra space detected where there should be no space.
Non-whitespace character(s) detected: "\".

app/views/admin/legislation/draft_versions/index.html.erb

    
            @@ -38,7 +38,7 @@
          
                          <td>

                            <% if draft_version.status == "draft" %>

                              <%= t("admin.legislation.draft_versions.statuses.draft") %>

                              <%= link_to "(#{t('.preview')})", legislation_process_draft_version_path(@process, draft_version)  %>

                              <%= link_to "(#{t(".preview")})", legislation_process_draft_version_path(@process, draft_version)  %>

houndci-bot Mar 25, 2019

Use 1 space before %> instead of 2 space.

app/helpers/valuation_helper.rb

    
            @@ -18,7 +18,7 @@ def assigned_valuators_info(valuators)
          
                  when 0

                    t("valuation.budget_investments.index.no_valuators_assigned")

                  when 1

                    "<span title=\"#{t('valuation.budget_investments.index.valuators_assigned', count: 1)}\">".html_safe +

                    "<span title=\"#{t("valuation.budget_investments.index.valuators_assigned", count: 1)}\">".html_safe +

houndci-bot Mar 25, 2019

Metrics/LineLength: Line is too long. [108/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

javierm force-pushed the double_quotes branch 2 times, most recently from 96c31e2 to 0ad0878 Compare

March 25, 2019 12:43

javierm added 3 commits

March 25, 2019 14:58


          Use double quotes in config/locales

d894d24


          Use double quotes inside string interpolation

4c35df4


          Use double quotes inside ERB

3e4e65e

We were using single quotes inside ERB code when that code was inside
HTML double quotes.

javierm force-pushed the double_quotes branch from 0ad0878 to 3e4e65e Compare

March 25, 2019 13:59

microweb10 approved these changes

View reviewed changes

voodoorai2000 approved these changes

View reviewed changes

javierm merged commit ac58b87 into master

javierm deleted the double_quotes branch

March 27, 2019 14:53

voodoorai2000 added the Tech label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet