Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Simplify legislation proposals customization #2946

Merged
merged 5 commits into from
Oct 4, 2018
Merged

[Backport] Simplify legislation proposals customization #2946

merged 5 commits into from
Oct 4, 2018

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 3, 2018

References

Objectives

  • Ease the backport of Allow select winner legislation proposals AyuntamientoMadrid/consul#1640, since it's related to the actions in legislation proposals.
  • Make it easier to change the code related to legislations proposals, so we don't have to edit two views or two controllers each time we want to change something.
  • Reduce the differences between CONSUL's repository and Decide Madrid's repository.

javierm added 5 commits October 3, 2018 22:05
@javierm
Use absolute translation paths
5ab8587 
Using `t(.empty_proposals)` IMHO is a bit dangerous because we'd need to
change the locale files if we move the code to a partial or rename the
file.
@javierm
Add variety to legislation process dev seeds
8064b53 
This way different processes will be in different phases and it will be
easier to test the application locally.
@javierm
Authorize resource after authenticating user
ec18743 
Just like it's done everywhere else in the application. Not doing so
means users who aren't logged in receive a "you aren't authorized"
message when they try to create a new legislation proposal instead of
being redirected to the login page.
@javierm
Extract link text to a helper
f93281f 
This way we can use the same code in custom views which won't use the
same text.
@javierm
Extract partial for proposals content
acbf20c
@javierm javierm merged commit c7a21e5 into master Oct 4, 2018
@javierm javierm deleted the backport-customize_proposals_view branch October 4, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decabeza decabeza decabeza approved these changes

@voodoorai2000 voodoorai2000 voodoorai2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javierm @voodoorai2000 @decabeza