Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite nodes version 2 #867

Closed
1 task done
antares1470 opened this issue Oct 21, 2020 · 4 comments
Closed
1 task done

Composite nodes version 2 #867

antares1470 opened this issue Oct 21, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@antares1470
Copy link
Collaborator

antares1470 commented Oct 21, 2020

Prerequisites

Description

We've identified issues with composite nodes on large graphs (especially those with a lot of transactions) and unexpected behaviours when you copy composite nodes between graphs.

The existing version will remain an experimental feature with a plan to create a newer version from lessons learned. Re-writing is the way to go because trying to fix the issue created other problems.

With the current implementation the approach was to go with a "light" implementation which means it didn't affect the structure of the core graph. This has created limitations so with the new version we will be creating a composite node element on the graph which will require an update to the schema.

@antares1470 antares1470 added the enhancement New feature or request label Oct 21, 2020
@github-actions
Copy link

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

@arcturus2
Copy link
Collaborator

Until composite nodes gets used in anger I'm tempted to close this and move it to the wiki backlog.

@github-actions
Copy link

This issue is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this issue.

@aldebaran30701
Copy link
Contributor

Closing this ticket and adding to the Brainstorm Ideas List.
Large ticket, where the current implementation does work, just not well for large compositions. This can get reopened if there is a specific need to completely review the current composite implementation.
https://github.com/constellation-app/constellation/wiki/Brainstorm-Ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants