Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash if progress stops #554

Closed
conradoplg opened this issue Jun 27, 2023 · 2 comments
Closed

Crash if progress stops #554

conradoplg opened this issue Jun 27, 2023 · 2 comments

Comments

@conradoplg
Copy link
Contributor

conradoplg commented Jun 27, 2023

If progress stops and an ETA is being displayed, it will eventually crash after overflowing.

This modified download.rs shows this. It crashes after some minutes.

use std::thread;
use std::time::Duration;
use std::{cmp::min, fmt::Write};

use indicatif::{ProgressBar, ProgressState, ProgressStyle};

fn main() {
    let mut downloaded = 0;
    let total_size = 231231231;

    let pb = ProgressBar::new(total_size);
    pb.set_style(ProgressStyle::with_template("{spinner:.green} [{elapsed_precise}] [{wide_bar:.cyan/blue}] {bytes}/{total_bytes} ({eta})")
        .unwrap()
        // .with_key("eta", |state: &ProgressState, w: &mut dyn Write| write!(w, "{:.1}s", state.eta().as_secs_f64()).unwrap())
        .progress_chars("#>-"));

    let mut packet = 1;
    while downloaded < total_size {
        let new = min(downloaded + packet, total_size);
        packet = packet.saturating_sub(1);
        downloaded = new;
        pb.set_position(new);
        thread::sleep(Duration::from_millis(12));
    }

    pb.finish_with_message("downloaded");
}

I'll open a PR shortly with a possible solution.

@teor2345
Copy link

Closed by #555?

@djc
Copy link
Member

djc commented Jun 29, 2023

Yup, thanks.

@djc djc closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants