Use canonical header keys to extract needed header attributes #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ohad Abarbanel <ohada@tannin.io>
ohad83
force-pushed
the
fix/canonical-headers
branch
from
63d2756
to
eca31f9
Compare
ohad83
changed the title
|
@ohad83, are you encountering an actual issue? If so, could you elaborate? Use of this method should not be necessary because we canonicalize all of the keys first, specifically so we can do direct map queries (to reduce performance overhead): |
|
Hmm, I see that now. I was having a problem with differences between environments where proxies change headers, so I figured that would be the case. I'll try digging into it some more to make sure canonicalization isn't the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extracting headers from
http.Header, it's better to useValuesinstead of accessing the map directly, since it canonicalizes the key before checking it. Many proxies and interceptors canonicalize header keys before forwarding them, so headers could have been omitted without this fix.