Fix build breakage caused by KAFKA-14334 #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KAFKA-14334 changed a kafka.utils.TestUtils method by adding a default argument (Scala). Unfortunately this is a breaking change for Java downstream dependencies.
dimitarndimitrov
requested review from
jliunyu,
TemirAskhat,
msn-tldr and
ehumber
|
I'll be merging this immediately without waiting for the PR CI results as is the accepted practice for build breakage fixes. |
philipnee
pushed a commit
that referenced
this pull request
Feb 22, 2023
KAFKA-14334 changed a kafka.utils.TestUtils method by adding a default argument (Scala). Unfortunately this is a breaking change for Java downstream dependencies.
philipnee
added a commit
that referenced
this pull request
Feb 23, 2023
Fix build breakage caused by KAFKA-14334 (#1083)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAFKA-14334 changed a kafka.utils.TestUtils method by adding a default argument (Scala). Unfortunately this is a breaking change for Java downstream dependencies.
Verified with a local
mvn clean package -DskipTestsbuild.