Ignore .condarc files during installation #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
3 tasks
3 tasks
jezdez
requested changes
Sep 20, 2024
jaimergp
reviewed
Sep 28, 2024
constructor/main.py
Outdated
| @@ -197,6 +197,15 @@ def main_build(dir_path, output_dir='.', platform=cc_platform, | |||
| ) | |||
| ) | |||
|
|
|||
| # Add --no-rc option to CONDA_EXE command so that existing | |||
| # .condarc files do not pollute the installation process. | |||
| if exe_name == "conda-standalone" and Version(exe_version) >= Version("24.9.0"): | |||
There was a problem hiding this comment.
Suggested change
| if exe_name == "conda-standalone" and Version(exe_version) >= Version("24.9.0"): | |
| if exe_name == "conda-standalone" and exe_version and Version(exe_version) >= Version("24.9.0"): |
Protect against exe_version = None.
|
Even if approved, we should probably wait with merging this until |
jaimergp
approved these changes
Oct 3, 2024
jezdez
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
conda-standaloneandmicromambaload existing.condarcfiles during the installation process, which can have unintended consequences and even break the installation. These issues have been frequently reported (see #542, #568, and the issues reported therein). The behavior of the installer should be set by the installer itself and not by residual configuration files, especially since they are not cleaned up at all (see #642).micromambahas a--no-rcoption, which is also proposed to be added toconda-standalone(conda/conda-standalone#99). This feature will add the--no-rcoption with compatible standalone executables.Closes #542 and #568.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?