Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta-issue] Upstreaming changes from custom fork #497

Closed
6 of 7 tasks
jaimergp opened this issue Mar 10, 2022 · 2 comments · Fixed by #474
Closed
6 of 7 tasks

[Meta-issue] Upstreaming changes from custom fork #497

jaimergp opened this issue Mar 10, 2022 · 2 comments · Fixed by #474
Labels
epic a highlevel collection of smaller related issues locked [bot] locked due to inactivity source::partner created by or for an Anaconda, Inc. partner company

Comments

@jaimergp
Copy link
Contributor

jaimergp commented Mar 10, 2022

I've been working on a constructor fork for several months now, which implements several open issues here as well as other features. I have some time now so I will begin to upstream those changes. I will use this issue to track progress:

@beeankha beeankha added epic a highlevel collection of smaller related issues source::partner created by or for an Anaconda, Inc. partner company backlog issue has been triaged but has not been earmarked for any upcoming release labels Mar 31, 2022
@kenodegard kenodegard removed the backlog issue has been triaged but has not been earmarked for any upcoming release label Jun 22, 2022
@jaimergp
Copy link
Contributor Author

jaimergp commented Jul 6, 2022

Hi @conda/constructor! I hope this tag works, I think it's the first we are using it!

This team was created to help maintain constructor and related tooling and I figured I could ask for a couple reviews in the PRs mentioned in the comment above. These changes have been part of the napari fork I've been maintaining for some months, so they should work quite ok, but maybe there are rough edges in some cases.

Anyway, I would be super happy if an extra pair of eyes could give it a read and tell me what they think.

@larsoner
Copy link

larsoner commented Jul 6, 2022

These changes have been part of the napari fork I've been maintaining for some months, so they should work quite ok, but maybe there are rough edges in some cases.

@hoechenberger has also successfully used them in https://github.com/mne-tools/mne-installers for the last ~6 months so we have some evidence that things work. I'll take a look, @hoechenberger if you could look, too, that would be great!

@jaimergp jaimergp linked a pull request Dec 18, 2023 that will close this issue
10 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
epic a highlevel collection of smaller related issues locked [bot] locked due to inactivity source::partner created by or for an Anaconda, Inc. partner company
Projects
Status: 🏁 Finished
Development

Successfully merging a pull request may close this issue.

4 participants