Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for alternative compressors for mksquashfs #274

Closed
2 tasks done
dmargala opened this issue Jul 13, 2023 · 2 comments
Closed
2 tasks done

Add support for alternative compressors for mksquashfs #274

dmargala opened this issue Jul 13, 2023 · 2 comments
Labels
stale [bot] marked as stale due to inactivity type::feature request for a new feature or capability

Comments

@dmargala
Copy link

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

Add a conda-pack cli option to specify a compressor for mksquashfs or have conda-pack automatically select a compressor that is supported by the mksquashfs in the user's environment.

Why is this needed?

Currently, conda-pack does not allow the user to select an arbitrary compressor for mksquashfs. It looks like there is a heuristic that uses the --compress-level cli option to select a compressor but the only compressors it can choose from are zstd or xz. The mksquashfs in my environment does not support either of those, it looks like my mksquashfs only supports gzip and lz4. Adding support for alternative compressors would allow users with mksquashfs that do not support zstd or xz to use compression when packing environments to squashfs.

What should happen?

From a user perspective, I would like to see a conda-pack cli option to specify a compressor or have conda-pack automatically select a compressor that is supported by the mksquashfs in my environment if possible.

Additional Context

It looks like there are conda-pack squashfs compression performance tests documented in #176 and there has been discussion about which compressors to support in #177. I appreciate the log message solution arrived at there, it helped me figure out where to look next. However, the suggestion to use xz instead of zstd is not always viable.

@dmargala dmargala added the type::feature request for a new feature or capability label Jul 13, 2023
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Jul 13, 2024
@dmargala
Copy link
Author

It turns out that the version of mksquashfs that is available on the system I am using is a custom static build with limited compression support. I don't have any control over that but I can work around the issue by installing the squashfs-tools package in my conda environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot] marked as stale due to inactivity type::feature request for a new feature or capability
Projects
Archived in project
Development

No branches or pull requests

1 participant