Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the location of PyPI/Conda package mapping file configurable #205

Closed
skumagai opened this issue Jul 4, 2022 · 3 comments · Fixed by #225
Closed

Making the location of PyPI/Conda package mapping file configurable #205

skumagai opened this issue Jul 4, 2022 · 3 comments · Fixed by #225

Comments

@skumagai
Copy link

skumagai commented Jul 4, 2022

Hi,

I don't have access to Github at work as my environment is behind a corporate firewall that blocks github.com/githubusercontent.com. This poses a problem when my environment.yml contains some pip-based dependencies.

If I understand correctly, get_forward_lookup (in lookup.py) tries to download a mapping file from a hardcoded URL, which is on githubusercontent.com. conda-lock fails because of that.

Can you make the location of the mapping file configurable (as noted in a todo comment on line 10)? If it is configurable, I can host the file by mirroring regro/cf-graph-countyfair inside of my organization to make it available.

I'm willing to work on this if you can give me some pointers (such as preference on env var vs command line argument).

@rphel
Copy link
Contributor

rphel commented Jul 22, 2022

Hello, we also encounter issues when using conda-lock in private network with no access to github.com.

A configurable location can be a good improvement, but this will not really help in our case as we cannot mirror github.com. Is it possible to have a different implementation that look for Pypi packages without this lookup table?

@rphel
Copy link
Contributor

rphel commented Jul 25, 2022

I made some changes to pass the location of the lookup file as a command line argument. MR link: #225
Can someone review this please?

@skumagai
Copy link
Author

Given my inability to access the Internet is due to my development environment, wouldn't it make sense to also handle this as an environment variable (or in a configuration file)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants