Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming changes in mamba context breaks conda-libmamba-solver #192

Closed
2 tasks done
costrouc opened this issue Apr 24, 2023 · 3 comments · Fixed by #193
Closed
2 tasks done

Upcoming changes in mamba context breaks conda-libmamba-solver #192

costrouc opened this issue Apr 24, 2023 · 3 comments · Fixed by #193
Assignees
Labels
locked [bot] locked due to inactivity pending::discussion contains some ongoing discussion that needs to be resolved prior to proceeding severity::1 blocker; broken functionality with no workaround type::bug describes erroneous operation, use severity::* to classify the type

Comments

@costrouc
Copy link
Contributor

costrouc commented Apr 24, 2023

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

The following commit to mamba mamba-org/mamba#2432 changes the way in which the context object is constructed. This means the next libmambapy version will break conda-libmamba-solver. Will be opening a PR on the fixes but the bigger question is how to preserve compatibility with older libmamba versions.

We are going to have to continue with repodata patches potentially due to this? Hope this issue/PR opens a larger discussion.

ctx = libmambapy.context.Context()
ctx.json # Attribute Error
ctx.output_config.json # exists 
@costrouc costrouc added the type::bug describes erroneous operation, use severity::* to classify the type label Apr 24, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Apr 24, 2023
@costrouc costrouc self-assigned this Apr 24, 2023
@costrouc costrouc moved this from 🆕 New to 🏗️ In Progress in 🧭 Planning Apr 24, 2023
@costrouc costrouc moved this from 🏗️ In Progress to 👀 In Review in 🧭 Planning Apr 24, 2023
@jezdez
Copy link
Member

jezdez commented Apr 26, 2023

Generally speaking we should have a close feedloop with the mamba maintainers about these changes and encourage no breaking/API changes in dot releases. Repodata patching is okay if there is no other way to keep the API from breaking, although I'd hope we could collaborate on feature changes ahead of time instead of running into the problem again and again.

@AntoinePrv Would you be interested in joining the conda-libmamba-solver team to improve the communication when you plan or conduct changes upstream? Right now it's just @wolfv and this might not be enough for a high bandwidth communicatino.

Also, is there anything the conda-libmamba-solver team can do to make it easier for us to stay aligned?

@jezdez jezdez added severity::1 blocker; broken functionality with no workaround pending::discussion contains some ongoing discussion that needs to be resolved prior to proceeding labels Apr 26, 2023
@jezdez jezdez added this to the Unassigned release milestone Apr 26, 2023
@AntoinePrv
Copy link

@jezdez I'd be happy to join, where can I find he details? If you have more concerns, also feel free to attend the bi-weekly mamba community meeting.

We are working on a big refactoring, completely restructuring the internals of libmamba, but we are committed to not break the libmambapy on patch and minor releases (major release will come by the end of the year).

Regarding, mamba-org/mamba#2432, I think @jaimergp and @Hind-M clarified changes yesterday.

@Hind-M
Copy link

Hind-M commented Apr 26, 2023

The changes concerning the Context are not included in the releases. And we are also planning a PR to still have both APIs supported. The best way to be updated regarding the ongoing work on mamba is to attend the mamba meeting as suggested by Antoine indeed :)

@github-project-automation github-project-automation bot moved this from 👀 In Review to 🏁 Done in 🧭 Planning Jul 17, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity pending::discussion contains some ongoing discussion that needs to be resolved prior to proceeding severity::1 blocker; broken functionality with no workaround type::bug describes erroneous operation, use severity::* to classify the type
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants