Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLA workflow needs to use same sort as pre-commit #105

Closed
kenodegard opened this issue May 17, 2023 · 0 comments · Fixed by #104
Closed

CLA workflow needs to use same sort as pre-commit #105

kenodegard opened this issue May 17, 2023 · 0 comments · Fixed by #104
Assignees
@kenodegard
Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::bug describes erroneous operation, use severity::* to classify the type

Comments

@kenodegard
Copy link
Contributor

kenodegard commented May 17, 2023 •
edited
Loading

What happened?

check-cla action sorts usernames via:

actions/check-cla/action.yml

Line 136 in 348cae4

signees["contributors"].sort()

this results in pre-commit resorting the usernames once the PR is opened:
sorted(set(value), key=str.lower)
@kenodegard kenodegard added type::bug describes erroneous operation, use severity::* to classify the type in-progress issue is actively being worked on source::anaconda created by members of Anaconda, Inc. labels May 17, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning May 17, 2023
@kenodegard kenodegard moved this from 🆕 New to 👀 In Review in 🧭 Planning May 17, 2023
@kenodegard kenodegard mentioned this issue May 17, 2023
Merged
@kenodegard kenodegard self-assigned this May 17, 2023
@travishathaway travishathaway moved this from 👀 In Review to ✅ Approved in 🧭 Planning May 26, 2023
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🧭 Planning Jun 2, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jun 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kenodegard kenodegard

Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::bug describes erroneous operation, use severity::* to classify the type
Projects
🧭 Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLA sort is case insensitive conda/actions
1 participant
@kenodegard