-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow relative paths for sources #229
Comments
A sensible approach might be to restore the old behavior unless the source path is absolute, so absolute source paths (possibly including the drive) would stay as absolute. This should still address #175 but keep the (more sensible?) behavior for the other cases |
Actually, #189 might have introduced an inconsistency with the logic (from df566dc) for reconstructing the source file path from the lock file itself if not specified which is probably broken: I haven't tested it, but I assume "reconstruct native paths" would fail for absolute paths in I think the "sensible approach" hinted above would be easily to mirror in a consistent way in this logic as well. I will try to draft a PR. |
Just wanted to leave a note that I support an opt-in (or at the very least optional) use of absolute paths. In our use case, we have multiple contributors who might update the lock files locally, and with absolute paths |
@JessicaS11 I'm curious about your use case for opt-in of absolute paths. Would you want the path to the source file |
Since #189, paths stored in the lockfile are stored as absolute, to address the issue in #175 where the lockfile and the sources are not on the same drive.
However, there was probably a point in relative paths and the change has its drawback for other (more common?). Consider sources and lockfiles maintained under version control in the same repo: one wouldn't want to produce and push lockfiles containing references to the absolute path of the local checkout.
I think using absolute paths should be opt-in, or used in case the construction of relative paths does not work.
The text was updated successfully, but these errors were encountered: