Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to mark sccache 0.7.4 as broken #41

Open
1 task done
robertmaynard opened this issue Feb 8, 2024 · 3 comments
Open
1 task done

Need to mark sccache 0.7.4 as broken #41

robertmaynard opened this issue Feb 8, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@robertmaynard
Copy link

Solution to issue cannot be found in the documentation.

  • I checked the documentation.

Issue

The 0.7.4 release of sccache has a serious regression in hash computation, which causes multiple unique compile lines to hash to the same value ( mozilla/sccache#2038 )

> cat verify.cpp
#ifdef GEN_ERROR
# error "expected error"
#endif
> g++ -o build/verify.o -c verify.cpp
> g++ -DGEN_ERROR -o build/verify.o -c verify.cpp

verify.cpp:4:3: error: #error "expected error"

> sccache g++ -o build/verify.o -c verify.cpp 
> sccache g++ -DGEN_ERROR -o build/verify.o -c verify.cpp # no error



### Installed packages

```shell
sccache = 0.7.4

Environment info

active environment : None
            shell level : 0
       user config file : /home/rmaynard/.condarc
 populated config files : /home/rmaynard/.condarc
          conda version : 23.9.0
    conda-build version : 3.27.0
         python version : 3.11.4.final.0
       virtual packages : __archspec=1=x86_64
                          __cuda=12.0=0
                          __glibc=2.31=0
                          __linux=5.4.0=0
                          __unix=0=0
       base environment : /home/rmaynard/miniconda3  (writable)
      conda av data dir : /home/rmaynard/miniconda3/etc/conda
  conda av metadata url : None
           channel URLs : https://conda.anaconda.org/conda-forge/linux-64
                          https://conda.anaconda.org/conda-forge/noarch
                          https://repo.anaconda.com/pkgs/main/linux-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/linux-64
                          https://repo.anaconda.com/pkgs/r/noarch
          package cache : /home/rmaynard/miniconda3/pkgs
                          /home/rmaynard/.conda/pkgs
       envs directories : /home/rmaynard/miniconda3/envs
                          /home/rmaynard/.conda/envs
               platform : linux-64
             user-agent : conda/23.9.0 requests/2.31.0 CPython/3.11.4 Linux/5.4.0-169-generic ubuntu/20.04.6 glibc/2.31 solver/libmamba conda-libmamba-solver/23.7.0 libmambapy/1.4.1
                UID:GID : 1000:1000
             netrc file : None
           offline mode : False
@robertmaynard robertmaynard added the bug Something isn't working label Feb 8, 2024
@jakirkham
Copy link
Member

Looks like this is fixed with PR ( mozilla/sccache#2039 ) in 0.7.6+. Is that right?

@bdice
Copy link

bdice commented Feb 8, 2024

Yes. There are no releases of 0.7.5 on conda-forge, so I think only these packages are affected:

https://anaconda.org/conda-forge/sccache/files?version=0.7.4

win-64/sccache-0.7.4-hdbe9166_0.conda
osx-arm64/sccache-0.7.4-hc33459c_0.conda
osx-64/sccache-0.7.4-hdd7f814_0.conda
linux-aarch64/sccache-0.7.4-h5a25046_0.conda
linux-64/sccache-0.7.4-h06160fa_0.conda

@jakirkham
Copy link
Member

@conda-forge/sccache , what do you think about marking the packages above broken?

As noted by Rob above, those versions are not caching effectively, which seems undesirable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants