Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with cython #152

Closed
dhirschfeld opened this issue Dec 2, 2020 · 2 comments
Closed

Build with cython #152

dhirschfeld opened this issue Dec 2, 2020 · 2 comments

Comments

@dhirschfeld
Copy link
Member

I'm sure all the contributors here are across it, but just so the conda package doesn't get forgotten, it would be good for distributed to be as fast as possible and hence to be built with cython

xref: dask/distributed#4292

@jakirkham
Copy link
Member

Actually I'd recommend holding off on this for a bit. Am saying this for a few reasons:

  1. A release is planned for next week and we only started doing this work this week
  2. Only a relatively small amount of stuff has been Cythonized in master (more to come)
  3. Outside of myself and some CI testing, not sure that it has seen broad enough usage yet

For these reasons, it seems reasonable to make this an opt-in thing for now as opposed to opt-out. Given there is a build flag, hopefully it's not too difficult for folks to opt-in.

That all being said, I would like to get more folks to try this and share feedback in the near future. Just not sure we are ready for conda-forge scale of folks trying this yet. Maybe in another release or so that will change. Hope that makes sense 🙂

@jakirkham
Copy link
Member

As upstream issue ( dask/distributed#4442 ) is tracking this, am going to close this out so we can track over there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants