Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default branches that are ignored by smithy for uploads #1904

Open
beckermr opened this issue Apr 4, 2024 · 2 comments
Open

add default branches that are ignored by smithy for uploads #1904

beckermr opened this issue Apr 4, 2024 · 2 comments

Comments

@beckermr
Copy link
Member

beckermr commented Apr 4, 2024

Right now, one can set an appropriate key in the conda-forge.yml to have smithy only do uploads for certain branches. This is useful, but @jaimergp and I discussed a separate scheme that we think could be a nice default and enable some new things. The idea is to always disallow uploads from anything that matches the following globs/regex:

  • _* (i.e., any branch that starts with an underscore)
  • (^[a-z,A-Z,_,\-,0-9]+)(-patch-)([0-9]+$) (i.e., any branch that matches the pattern of default GH branch names for edits in the UI, <username>-patch-<number>.
  • any branch that matches the default branch name for PR reversions (need to look this up)

If we moved to this system, then we'd avoid common user errors of uploads happening when they do not fork the feedstock and we could use branches that start with _ for automated tasks like rerendering.

Thoughts @conda-forge/core?

@h-vetinari
Copy link
Member

Why not do an allowlist instead of a blocklist? Something like main|dev|rc + ^v?[\d\.]+(\.x)?$; or maybe just main and enable extending that list through conda-forge.yml?

In any case, an allowlist seems way more waterproof than chasing holes in our blocklists to me.

@beckermr
Copy link
Member Author

beckermr commented Apr 4, 2024

I don't care how it is phrased so happy with whatever in terms of allow vs reject lists.

One vote in favor of an expanded reject list is that if we instated allow lists we'd probably break existing feedstocks at some point.

The big point here, however, is that our current default of allowing everything is not as useful as several other possible default choices and I think we should change it.

@beckermr beckermr changed the title add default branches that are ignore by smithy for uploads add default branches that are ignored by smithy for uploads Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants