SSH Runner: Fix several issues and refactor code #17357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perseoGI
force-pushed
the
pgi/ssh-runner
branch
from
cf0893c to
6c7b1b8
Compare
memsharded
reviewed
Dec 18, 2024
conan/api/subapi/cache.py
Outdated
| @@ -214,7 +214,7 @@ def restore(self, path): | |||
| unzipped_metadata_folder = pref_bundle.get("metadata_folder") | |||
| if unzipped_metadata_folder: | |||
| # FIXME: Restore metadata is not incremental, but destructive | |||
| out.info(f"Restore: {pref} metadata in {unzipped_metadata_folder}") | |||
| out.info(f"Restore: {pref} metadata from {unzipped_metadata_folder}") | |||
There was a problem hiding this comment.
It is not restoring from, it is restoring in, the folder is the destination folder
conan/api/subapi/cache.py
Outdated
| @@ -199,7 +199,7 @@ def restore(self, path): | |||
| pkg_layout = cache.create_pkg_layout(pref) # DB Folder entry | |||
| # FIXME: This is not taking into account the existence of previous package | |||
| unzipped_pkg_folder = pref_bundle["package_folder"] | |||
| out.info(f"Restore: {pref} in {unzipped_pkg_folder}") | |||
| out.info(f"Restore: {pref} from {unzipped_pkg_folder}") | |||
There was a problem hiding this comment.
It is not restoring from, it is restoring in, the folder is the destination folder
| def __init__(self, conan_api, command, host_profile, build_profile, args, raw_args): | ||
| from paramiko.config import SSHConfig | ||
| from paramiko.client import SSHClient | ||
| def __init__( |
There was a problem hiding this comment.
Avoid formatting and typing changes, it makes difficult to read the changelog and check if some new argument was added to the constructor
perseoGI
commented
Dec 18, 2024
perseoGI
force-pushed
the
pgi/ssh-runner
branch
from
ff37095 to
5032b3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Finish
SSH Runnerby removing several bugsDocs: TODO
Changes:
jinja2templates intact to allow remote runner to render them locallybuildrecipes. Solved by always exporting all the packages and forcing a local cache refresh&and*during ssh remote invoquesdevelopbranch, documenting this one.