Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix_path not necessary here #8540

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

memsharded
Copy link
Member

Changelog: Omit
Docs: Omit

Seems unix_path is not necessary here

@memsharded memsharded added this to the 1.34 milestone Feb 22, 2021
@memsharded memsharded requested a review from SSE4 February 22, 2021 23:37
@memsharded
Copy link
Member Author

@SSE4 please review. We need to make sure to remain minimal and have red/green tests for the functionality that is being tested or covered.

@SSE4
Copy link
Contributor

SSE4 commented Feb 23, 2021

interesting. the path is passed into bash (cd) command. for me, it clearly didn't work without unix_path, I wonder how does it work for you?

@memsharded memsharded marked this pull request as ready for review February 23, 2021 10:56
@SSE4
Copy link
Contributor

SSE4 commented Feb 23, 2021

okay, it didn't work without quotes, but it works with, for both msys and cygwin
msys2:

SSE4@DESKTOP-E3NFU1V MSYS ~
$ cd "C:\Windows"
SSE4@DESKTOP-E3NFU1V MSYS /c/Windows
$

cygwin:

SSE4@DESKTOP-E3NFU1V ~
$ cd "C:\Windows"
SSE4@DESKTOP-E3NFU1V /cygdrive/c/Windows
$

@memsharded memsharded merged commit 5a3a4e8 into conan-io:develop Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants