Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- check cmake #8492

Merged
merged 1 commit into from
Feb 23, 2021
Merged

- check cmake #8492

merged 1 commit into from
Feb 23, 2021

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Feb 12, 2021

see #8457

Changelog: Omit
Docs: Omit

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very good, great approach. Lets make sure that minimal CMake examples can be built in tests and in our infra, before suffering trying to build our Conan packages. Keep this going.

@SSE4 SSE4 closed this Feb 15, 2021
@SSE4 SSE4 reopened this Feb 15, 2021
@SSE4
Copy link
Contributor Author

SSE4 commented Feb 15, 2021

the error in CI is:

C:\msys64\mingw64\bin\gcc.exe      -Wl,--whole-archive CMakeFiles\cmTC_d4b34.dir/objects.a -Wl,--no-whole-archive  -o cmTC_d4b34.exe -Wl,--out-implib,libcmTC_d4b34.dll.a -Wl,--major-image-version,0,--minor-image-version,0 @CMakeFiles\cmTC_d4b34.dir\linklibs.rsp

E               collect2.exe: error: ld returned 5 exit status

locally, it doesn't reproduce, unfortunately.
status 5 sounds like an access violation, which might be a crash.
there are some conflicting tools already in the PATH on the CI, we need to keep digging with @czoido

Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4
Copy link
Contributor Author

SSE4 commented Feb 16, 2021

passed! thanks to @czoido !

@memsharded memsharded merged commit 32495a9 into conan-io:develop Feb 23, 2021
@memsharded memsharded added this to the 1.34 milestone Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants