Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS 2019 with older toolsets broken since 1.15.0 #5343

Closed
MarcelRaad opened this issue Jun 12, 2019 · 3 comments
Closed

VS 2019 with older toolsets broken since 1.15.0 #5343

MarcelRaad opened this issue Jun 12, 2019 · 3 comments
Assignees
@lasote
Labels
complex: medium priority: high type: bug
Milestone
1.16.1

Comments

@MarcelRaad
Copy link

This is the same as #5318, but for Visual Studio 2019.

With Visual Studio 2019 (16.0), you can also install the Visual Studio 2017 (v141) and 2015 (v140) build tools. This broke with 6d3282f, as only the v142 toolset can be used now if you don't have older IDEs installed.
@lasote lasote added this to the 1.16.1 milestone Jun 12, 2019
@lasote
Copy link
Contributor

lasote commented Jun 12, 2019

I agree the check is totally broken with the compiler.toolset usage. I see two options, or we check the toolset setting instead of the compiler version or we avoid the check if a toolset is specified.

@lasote lasote self-assigned this Jun 12, 2019
@lasote lasote mentioned this issue Jun 12, 2019
Merged
@memsharded
Copy link
Member

Fixed in #5348, will be released in 1.16.1 soon

@MarcelRaad
Copy link
Author

Wow, that was fast. Thanks a lot!

@MarcelRaad MarcelRaad mentioned this issue Jul 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lasote lasote

Labels
complex: medium priority: high type: bug
Projects
None yet
Milestone
1.16.1
Development

No branches or pull requests
3 participants
@lasote @MarcelRaad @memsharded