Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation message for cppinfo.cppflags #4337

Closed
lasote opened this issue Jan 18, 2019 · 1 comment · Fixed by #4611
Closed

Deprecation message for cppinfo.cppflags #4337

lasote opened this issue Jan 18, 2019 · 1 comment · Fixed by #4611
Assignees
@jgsogo
Labels
complex: low priority: high type: engineering
Milestone
1.13

Comments

@lasote
Copy link
Contributor

lasote commented Jan 18, 2019

Introduce a new alias of cppflags named cxxflags and change the docs. If possible, show a deprecation message when cppflags is used.
The choice of cppflags meaning c++flags was not good, because cppflags means preprocessor flags and it is confusing.
@lasote lasote changed the title Deprecate cppinfo.cppflags Deprecation message for cppinfo.cppflags Jan 18, 2019
@lasote lasote mentioned this issue Jan 18, 2019
Closed
@jgsogo
Copy link
Contributor

jgsogo commented Jan 18, 2019

May consider this check (raising an error) for the conan-center hook?, cc/ @danimtb

@lasote lasote added this to the 1.13 milestone Feb 5, 2019
@lasote lasote mentioned this issue Feb 5, 2019
Closed
@jgsogo jgsogo self-assigned this Feb 26, 2019
@jgsogo jgsogo mentioned this issue Feb 26, 2019
Merged
1 task
@ghost ghost removed the stage: in-progress label Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgsogo jgsogo

Labels
complex: low priority: high type: engineering
Projects
None yet
Milestone
1.13
Development

Successfully merging a pull request may close this issue.

Deprecate 'cppflags' in favor of 'cxxflags' in class CppInfo jgsogo/conan
2 participants
@jgsogo @lasote