Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-in global full_version instead of semver for package_id #4071

Closed
lasote opened this issue Dec 5, 2018 · 6 comments
Closed

Opt-in global full_version instead of semver for package_id #4071

lasote opened this issue Dec 5, 2018 · 6 comments

Comments

@lasote
Copy link
Contributor

lasote commented Dec 5, 2018

Consider adding an opt-in mechanism using the conan.conf to change the global behavior of the package_id method to default all packages (only default, not override if they have fine adjustments) so we can change the default semver to default full_version, that would be the default in Conan 2.0

Probably we should consider the default being configurable => full_package_id, full_version...

@puetzk
Copy link

puetzk commented Feb 16, 2019

I'd also really like to see this on a per-package basis, where a package could declare how strictly it maintained binary compatibility and have that change its default representation in a consumer's info.requires["x"]. Obviously the consumer's package_id function could still change this, but in general "which versions are binary compatible" is something better known by the libfoo recipe than by the consumer.

@niosHD
Copy link
Contributor

niosHD commented Feb 16, 2019

I agree, having the possibility to define the default binary compatibility (for consumers) within the package itself would be great. I have already encountered some difficulties due to the lack of this feature. (see conan-io/docs#3153)

@lasote
Copy link
Contributor Author

lasote commented Feb 20, 2019

@puetzk @niosHD Could you please open a new issue for that? you can reference this. There are two clearly different issues and won't be implemented together (we have first to agree on what you are suggesting). That is the only way we don't lose it when I close this one as "done".

@niosHD
Copy link
Contributor

niosHD commented Feb 20, 2019

conan-io/docs#3153 should suffice, doesn't it? I just referenced my issue since I wanted to establish the link and to make it easier discoverable it in the future. I think the suggestion that I make in conan-io/docs#3153 is exactly the same what @puetzk is asking for.

@lasote
Copy link
Contributor Author

lasote commented Feb 20, 2019

You are right.

@puetzk
Copy link

puetzk commented Feb 26, 2019

Yes, I agree conan-io/docs#3153 seems like a good discussion of the same issues I had in mind with libraries that do not use semver. I've subscribed on that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants