Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions between 0.29.2 and 0.30.1 #2149

Closed
theodelrieu opened this issue Dec 13, 2017 · 6 comments
Closed

Regressions between 0.29.2 and 0.30.1 #2149

theodelrieu opened this issue Dec 13, 2017 · 6 comments
Milestone

Comments

@theodelrieu
Copy link
Contributor

Hi!

I've downloaded the latest release earlier, and I had a weird bug (I failed to reproduce it with a minimal example...)

I have a package which has a build requirement on llvm/5.0@theo/stable. When running conan create I have an error at the test_package step, something about missing headers.

I dug up a bit and found something very strange with the generated conanbuildinfo.*:

[includedirs]
/Users/theo/.conan/data/llvm/5.0/theo/stable/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/c++/v1

[libdirs]
/Users/theo/.conan/data/mylib/0.1/theo/stable/package/134df78716d13a41ecdfe642041a3f27d5280323/lib

As you can see, the includedirs got overwritten by the llvm ones.

Funny enough, this only happens when running conan create... conan test works fine!
Here is the conanbuildinfo.txt generated by the latter command:

[includedirs]
/Users/theo/.conan/data/llvm/5.0/theo/stable/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include
/Users/theo/.conan/data/llvm/5.0/theo/stable/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/c++/v1
/Users/theo/.conan/data/mylib/0.1/theo/stable/package/134df78716d13a41ecdfe642041a3f27d5280323/include

[libdirs]
/Users/theo/.conan/data/mylib/0.1/theo/stable/package/134df78716d13a41ecdfe642041a3f27d5280323/lib

And the relevant lines in the conanbuildinfo.cmake:

set(CONAN_MYLIB_ROOT "/Users/theo/.conan/data/mylib/0.1/theo/stable/package/134df78716d13a41ecdfe642041a3f27d5280323")
set(CONAN_INCLUDE_DIRS_MYLIB )
set(CONAN_LIB_DIRS_MYLIB "/Users/theo/.conan/data/mylib/0.1/theo/stable/package/134df78716d13a41ecdfe642041a3f27d5280323/lib")

When running conan test:

set(CONAN_INCLUDE_DIRS_MYLIB "/Users/theo/.conan/data/mylib/0.1/theo/stable/package/134df78716d13a41ecdfe642041a3f27d5280323/include")

Reverting to 0.29.2 fixes the issue.
I tried to debug conan sources but my understanding of the code base + my python skills are a bit limited.

@memsharded
Copy link
Member

Thanks for the report. We will inmmediately have a look!

@memsharded
Copy link
Member

A couple of quick questions:

  • How is the build_require defined: in the profile applied to all packages?
  • What is your dependency graph: you have an app, that depends on mylib? Both of them have the build_require?

@memsharded
Copy link
Member

Reproduced, it comes from the usage of ycm generator.

@memsharded
Copy link
Member

memsharded commented Dec 13, 2017

@lasote lasote added this to the 0.30.2 milestone Dec 14, 2017
@lasote
Copy link
Contributor

lasote commented Dec 14, 2017

We've released 0.30.2, please try it and tell us if you find any problem.

@lasote lasote closed this as completed Dec 14, 2017
@lasote lasote added the fixed label Dec 14, 2017
@theodelrieu
Copy link
Contributor Author

It works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants