Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] 2.0 "skip confirmation" and "overwrite/delete" in the CLI should be consistent #12523

Closed
1 task done
prince-chrismc opened this issue Nov 13, 2022 · 5 comments
Closed
1 task done
Assignees
Milestone

Comments

@prince-chrismc
Copy link
Contributor

prince-chrismc commented Nov 13, 2022

Currently in 2.0 beta 5 theres are a few command flags that are still very awkward and each command has it's own special meanings. For example

$ conan upload -h
  --force               Force the upload of the artifacts even if the revision already exists in
                        the server
  --check               Perform an integrity check, using the manifests, before upload
  -c, --confirm         Upload all matching recipes without confirmation
$ conan remove -h
  -f, --force           Remove without requesting a confirmation

These two are the same, the upload cmd is missing the short hand -f and remove has a different meaning 🙈

$ conan new -h
  -f, --force           Overwrite file if exists
$ conan profile detect -h
  -f, --force           Overwrite file if exists
@memsharded
Copy link
Member

The shortcut for -f can definitely be added.
What do you suggest to improve the UI? conan remove -c?

@prince-chrismc
Copy link
Contributor Author

Definitely should be -c

I think remove could have both for UX. It's a common convention with rm -f it could be an alias for convience?

@memsharded
Copy link
Member

I think remove could have both for UX. It's a common convention with rm -f it could be an alias for convience?

This was our rationale.

But something that we are trying to do in 2.0 is remove ambiguity or redundancy. Having 2 different args to do exactly the same is not great, I'd prefer to chose one and use that one always. Lets get the team opinion too.

@memsharded memsharded added this to the 2.0.0-beta6 milestone Nov 14, 2022
@prince-chrismc
Copy link
Contributor Author

Lets commit to -c for confirm them 👍

@czoido
Copy link
Contributor

czoido commented Nov 30, 2022

Closed by #12636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants