Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] [develop2] Drop compatibility.py app_compat #12483

Closed
memsharded opened this issue Nov 7, 2022 · 1 comment
Closed

[bug] [develop2] Drop compatibility.py app_compat #12483

memsharded opened this issue Nov 7, 2022 · 1 comment

Comments

@memsharded
Copy link
Member

memsharded commented Nov 7, 2022

There is a problem with the 2.0 compatibility.py default application compability:

  • It tries to provide a fallback that allows requiring an package_type="application" with only os and arch defined in the settings in the profile or cli.
  • It works nicely for packages without transitive dependencies, proposing a fallback to the default compiler of each OS, latest version
  • But for application with transitive dependencies it fails with the compiler or compiler.version error message, because the compatibility.py only provides the fallback for applications, but not for regular libraries

The solutions could be:

  • Apply the fallback to all packages, always. Make sure of course that it only fallbacks for not defined settings. Not sure what is the value, compared with just explicitly defining in the profile the default desired settings
  • Drop the app_compat part completely.

A similar, alternative effect could be achieved by using the profile plugin to fill the voids in a profile, and that might also save some extra API calls maybe?

@czoido
Copy link
Contributor

czoido commented Nov 8, 2022

Closed by: #12484

@czoido czoido closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants