Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] entt/3.2.2 #550

Closed
Minimonium opened this issue Dec 28, 2019 · 8 comments · Fixed by #551
Closed

[request] entt/3.2.2 #550

Minimonium opened this issue Dec 28, 2019 · 8 comments · Fixed by #551

Comments

@Minimonium
Copy link
Contributor

Package Details

Description Of The Library / Tool

Gaming meets modern C++ - a fast and reliable entity-component system (ECS) and much more

CC @skypjack

@Minimonium
Copy link
Contributor Author

@skypjack
Just a heads up that the Conan Center Index supersedes the previous contribution model to the default Conan registry.
In the CCI we create separated from the main repository recipes. There are also more rules, like the ban on default build system files, like CMake config files. The idea is to fully generate them from Conan. So if you or your users have any problems with this new recipe please reach out. 🙂

@skypjack
Copy link

@Minimonium

Thank you very much for the heads up, really appreciated!
Is there any documentation for this new model? I missed it to be honest, my fault.
I understand correctly and can I remove support for Conan from the EnTT repository or is that still necessary?

@Minimonium
Copy link
Contributor Author

Minimonium commented Dec 28, 2019

If you don't need Conan as a vehicle to pull your dependencies then no you don't need it.

If you make a new release it's enough to make an issue here picking the Package: New Version issue template and we'll pick it up (or you or your users may make a PR request since we want to trivialize the process as much as possible into adding a pair of a version and a source archive hash 🙂 ).

There is some information in the wiki: https://github.com/conan-io/conan-center-index/wiki

@skypjack
Copy link

May I give you a feedback to improve the process?
Until now, when I pushed a tag, the CI was in charge to create a new package on my conan account.
It would be great if you provided an official GH action or something similar to automate the process, since just open a PR sounds a bit error-prone (I mean, I'm pretty sure I'll forget it sooner or later).

@Minimonium
Copy link
Contributor Author

You're absolutely right! We're looking into what can be done with that. I just outlined the current status.
Feedback is much appreciated. 🙂

@skypjack
Copy link

I'd be glad to test it if you'll ever provide users with an official GH action too. Count me in. 😉

@skypjack
Copy link

@Minimonium

Here is another feedback that can help you to improve the whole thing.
Is there an easy way to do what he mentions with the new model?

@danimtb
Copy link
Member

danimtb commented Dec 30, 2019

I think using the recipe directly and a conan source command before creating the workspace could work (haven't tried it). There are still things to consider and solve as discussed in #22 but if you are afraid of removing the recipe from the library repo, you can keep it and just stop generating the packages in the CI. That will allow people to maintain the local workflow but use the new packages generated by the CI in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants