Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] What are the obstacles of merging PCL library for now? #10976

Closed
hwhsu1231 opened this issue May 29, 2022 · 2 comments
Closed

[question] What are the obstacles of merging PCL library for now? #10976

hwhsu1231 opened this issue May 29, 2022 · 2 comments
Assignees
Labels
infrastructure Waiting on tools or services belonging to the infra question Further information is requested

Comments

@hwhsu1231
Copy link

PCL(Point Cloud Library) is a famous C++ library. However, I noticed that it is not supported in ConanCenter for now.

Originally, I decided to post a library request for it. Then, I found that there were already some PRs trying to merging this PCL library. However, they failed. What are the obstacles of merging PCL library for now?

For now, I'm not capable of helping this ,but I just hope PCL can be supported in ConanCenter as soon as possible.

@hwhsu1231 hwhsu1231 added the question Further information is requested label May 29, 2022
@SSE4 SSE4 added the infrastructure Waiting on tools or services belonging to the infra label May 30, 2022
@SSE4
Copy link
Contributor

SSE4 commented May 30, 2022

@jgsogo @davidsanfal we need to resume our investigation here.

@hwhsu1231 the problem is PCL requires a significant amout of memory to compile.
we have created a special cluster which contains nodes (=build agents) with more memory, but compilation still terminates in the nodes (perhaps, compiler got killed by OOM killer). my investigation shows it gots terminated before memory limit has been reached. moreover, it doesn't reproduce locally for me, so it's a bit tricky to figure out what's going on (probably, something is misconfigured).

@jcar87
Copy link
Contributor

jcar87 commented Aug 22, 2023

Closed via #18389 - thanks @EstebanDugueperoux2 for your efforts.

Thanks to the PCL maintainers and contributors as well - there is an investigation here related to high memory consumption during compilation due to template instantiations PointCloudLibrary/pcl#3414 (comment), which is addressed upstream in PointCloudLibrary/pcl#5764, as well as the PCL_ONLY_CORE_POINT_TYPES cmake option, which is enabled on all of PCLs CI plans.

@jcar87 jcar87 closed this as completed Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Waiting on tools or services belonging to the infra question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants