Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated submitOnce function in core #175

Open
colemanw opened this issue Jun 28, 2019 · 2 comments
Open

Deprecated submitOnce function in core #175

colemanw opened this issue Jun 28, 2019 · 2 comments

Comments

@colemanw
Copy link

The old submitOnce function from Common.js has been deprecated and will eventually be removed from CiviCRM core.
It is being called in an inline script in UpdateSubscriptionModifications.tpl. I wanted to submit a PR for removing it, but honestly I can't quite make sense of that code. I have the feeling that calling the function from there is unnecessary coupling and you could just trigger a click event instead, but I'm not entirely sure what that function is doing.

@omarabuhussein
Copy link
Member

hi @colemanw

sorry for the very late response, this is actually a good note so thanks for this, I will add it to our internal Jira, and try to get it fixed during one of the future releases.

@colemanw
Copy link
Author

colemanw commented Oct 6, 2020

Ok. Good luck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants