Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests against all Array/AbstractArray APIs #27

Closed
yebai opened this issue Nov 3, 2023 · 4 comments
Closed

Tests against all Array/AbstractArray APIs #27

yebai opened this issue Nov 3, 2023 · 4 comments

Comments

@yebai
Copy link
Contributor

yebai commented Nov 3, 2023

We should consider testing against all stdlib functions for Julia's Array type. A more comprehensive test should also include PDMats and Statistics.

See e.g. Tracker tests for an example.

@willtebbutt
Copy link
Member

This is, of course, a good idea. I'm not entirely sure what in the tracker tests you're referring to though -- that file looks like a fairly random collection of operations on arrays. Am I missing something?

@yebai
Copy link
Contributor Author

yebai commented Nov 3, 2023

I'm not entirely sure what in the tracker tests you're referring to though -- that file looks like a fairly random collection of operations on arrays. Am I missing something?

We can cherry-pick some tests from Tracker, but yes, it contains some other tests which might not be relevant.

@willtebbutt
Copy link
Member

I see.

A pretty good way to construct a very thorough test set is to just look at the results of

methodswith(Array, Base; supertypes=true)
methodswith(Vector, Base; supertypes=true)
methodswith(Array, LinearAlgebra; supertypes=true)
methodswith(Vector, LinearAlgebra; supertypes=true)

@willtebbutt
Copy link
Member

Closing in favour of #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants