Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌈Colorful output #22

Open
idubrov opened this issue Sep 19, 2019 · 3 comments
Open

🌈Colorful output #22

idubrov opened this issue Sep 19, 2019 · 3 comments
Labels
📈Enhancement New feature or request

Comments

@idubrov
Copy link
Contributor

idubrov commented Sep 19, 2019

Sourcegen could really use some help from colors on terminal and, maybe, add some smiley faces, too!

P.S. At very least, error messages should be clean and clear -- currently, when tool fails, it is not obvious that it did so.

@idubrov idubrov added the 📈Enhancement New feature or request label Sep 19, 2019
@idubrov
Copy link
Contributor Author

idubrov commented Apr 15, 2020

Another potential improvement: print list of modules / some basic stats where #[sourcegen] attributes were found, to help troubleshooting cases when module is not included by mistake -- which is a common thing when you are setting up new code!

@idubrov
Copy link
Contributor Author

idubrov commented Apr 15, 2020

Also: when it cannot process item (for example, was placed in front of invalid item type), should report it as well.

@idubrov
Copy link
Contributor Author

idubrov commented Apr 16, 2020

Another thing: if it fails to produce code because generated code is invalid (could happen when generation is driven off other files; for example, generated field name might be invalid Rust identifier), it reports an error in the file that doesn't yet exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant