GitHub organization approval criteria stopped working

[jarias-lfx]

Summary

Starting 2024-02-02 EasyCLA is not longer working for companies using GitHub Organization as the approval criteria

Background

Some companies use GitHub organization as the approval criteria, as long as the contributors are part of the GitHub Organization and the organization is public, EasyCLA should just ask the contributors for the acknowledgement. Starting 2024-02-02 the contributor now show with approved = false. Event when marking the user manually approved = true in the signatures table. It changes back to approved = false on PR update.

The Event appear as follows:

{
 "event_id": "c9323621-d0d7-4322-9db0-599fb4d5ebc5",
 "contains_pii": true,
 "date_created": "2024-02-02T18:40:41.672327+0000",
 "date_modified": "2024-02-02T18:43:36.425073+0000",
 "event_cla_group_name": "Cloud Foundry - Series LLCs",
 "event_cla_group_name_lower": "cloud foundry - series llcs",
 "event_company_id": "c02e9bdb-199e-44d3-a54f-9d94dfd7cddc",
 "event_company_name": "SAP",
 "event_company_name_lower": "sap",
 "event_company_sfid": "0014100000Te0dnAAB",
 "event_data": "The employee signature of user None was disapproved the during CCLA check for project Cloud Foundry - Series LLCs and company SAP",
 "event_data_lower": "the employee signature of user none was disapproved the during ccla check for project cloud foundry - series llcs and company sap",
 "event_date": "02-02-2024",
 "event_date_and_contains_pii": "02-02-2024#true",
 "event_project_name": "undefined",
 "event_project_name_lower": "undefined",
 "event_project_sfid": "a092M00001IkUMrQAN",
 "event_summary": "The employee signature of user None was disapproved the during CCLA check for project Cloud Foundry - Series LLCs and company SAP",
 "event_time": "2024-02-02T18:40:41.677328+0000",
 "event_time_epoch": 1706899241,
 "event_type": "EmployeeSignatureDisapproved",
 "event_user_id": "3cb03123-512b-48ff-8647-6091972d33ea",
 "version": "v1"
}

Expected behavior

EasyCLA shouldn't change the ECLA to approved=false automatically.

Environment

Please complete the following information:

• Environment:
  • ALL
  • DEV
  • STAGING
  • [ x ] PROD
• Browser:
  • [ x ] Chrome/Brave
  • Firefox
  • Opera
  • Vivaldi
  • LibreWolf
  • SRware Iron
  • Dissenter
  • Slimjet
  • Midori
  • Edge
  • Lynx

[jarias-lfx]

Affected PRs:

• [ARI] Add temp autoscaler team for managing GitHub secrets cloudfoundry/community#769
• Add Makefile (failing linters disabled) paketo-buildpacks/libpak#301
• Remove distinct cloudfoundry/cloud_controller_ng#3623
• Put service key binding/instance creation and job creation in one transaction cloudfoundry/cloud_controller_ng#3618
• Optimize "/ids/Users" endpoint cloudfoundry/uaa#2704
• Correct API declaration of GetResult to be nullable finos/fdc3-dotnet#110

[mlehotskylf]

The issue has been resolved. The root cause was an invalid GitHub token, which had either expired or been invalidated. We created a new GitHub token using the user account EasyCLA-Machine-User, which does not expire. After updating the GitHub token in the PROD, some of the previously failing PRs above still encountered issues. Upon further investigation, I found that the signature_approved field in the signatures table in DynamoDB was set to FALSE for users. By manually setting this field to TRUE for the users silvestre and c0d1ngm0nk3y, all the affected PRs above successfully passed the CLA check.

[thakurveerendras]

Tested the fix on production at the "Test Project IT" project & found that I can add & update the GitHub user name under approval list

[thakurveerendras]

[mlehotskylf]

@jarias-lfx please confirm this is working as expected (since you are the reporter) so we can close this ticket.
Thanks!

[jarias-lfx]

Confirmed working.