Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor Performance when large amount of users loaded #248

Closed
Airyzz opened this issue May 28, 2024 · 2 comments · Fixed by #249
Closed

Poor Performance when large amount of users loaded #248

Airyzz opened this issue May 28, 2024 · 2 comments · Fixed by #249

Comments

@Airyzz
Copy link
Contributor

Airyzz commented May 28, 2024

Describe the bug
At the moment, commet is lazily loading the room member list, and as a result there is not typically a large amount of users loaded - In the event that we end up with loading the entire member list, performance takes a significant hit

image
@Airyzz Airyzz mentioned this issue May 28, 2024
Merged
@Airyzz Airyzz linked a pull request May 29, 2024 that will close this issue
Refactor loading of room members #249
Merged
@Airyzz
Copy link
Contributor Author

Airyzz commented May 29, 2024

This should get resolved in #249 because that call to onRoomStateUpdated no longer exists, and is not needed

@Aranjedeath
Copy link

can confirm, #249 resolves the performance issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor loading of room members commetchat/commet
2 participants
@Aranjedeath @Airyzz