Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrysler ACC instant faults with latest master-ci build #24906

Closed
ns3284 opened this issue Jun 19, 2022 · 2 comments · Fixed by #24907
Closed

Chrysler ACC instant faults with latest master-ci build #24906

ns3284 opened this issue Jun 19, 2022 · 2 comments · Fixed by #24907
Labels
bug car vehicle-specific chrysler

Comments

@ns3284
Copy link

ns3284 commented Jun 19, 2022

Describe the bug

Can't enable ACC with Comma 3 device plugged in. Controls unresponsive on steering wheel until system ultimately faults. Works fine when comma device is unplugged.

Which car does this affect?

Chrysler Pacifica 2022

Provide a route where the issue occurs

4395faadf0a373f2|2022-06-19--15-41-19--0

openpilot version

0.8.15 Nightly (6/19/2022)

Additional info

No response

@adeebshihadeh
Copy link
Contributor

Thanks for reporting this! Looks like it was caused by 0f0b4ca, so I reverted it on master. @sshane why didn't any tests catch this?

@adeebshihadeh adeebshihadeh added bug car vehicle-specific chrysler labels Jun 19, 2022
@sshane
Copy link
Contributor

sshane commented Jun 20, 2022

The segment in test_processes is only available and engaged so flipping them has no effect. We should soon try to get more comprehensive routes, and test more things like doors, blinkers, gas, etc. For now I added a test in test_models

@sshane sshane linked a pull request Jun 20, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug car vehicle-specific chrysler
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants