Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chyrlser: resume ACC from standstill #24883

Closed
adeebshihadeh opened this issue Jun 16, 2022 · 2 comments · Fixed by #25009
Closed

Chyrlser: resume ACC from standstill #24883

adeebshihadeh opened this issue Jun 16, 2022 · 2 comments · Fixed by #25009
Labels
Milestone

Comments

@adeebshihadeh
Copy link
Contributor

No description provided.

@adeebshihadeh adeebshihadeh added this to the 0.8.15 milestone Jun 16, 2022
@adeebshihadeh adeebshihadeh added car vehicle-specific chrysler labels Jun 17, 2022
@sshane
Copy link
Contributor

sshane commented Jun 17, 2022

Spamming both busses should work according to @realfast

@realfast
Copy link
Contributor

realfast commented Jun 17, 2022

I am sure there is a better way

I did the following in carcontroller:

if CC.cruiseControl.cancel:
      can_sends.append(create_wheel_buttons(self.packer, CS.button_counter + 1, 0, cancel=True, acc_resume = False))
      can_sends.append(create_wheel_buttons(self.packer, CS.button_counter + 1, 2, cancel=True, acc_resume = False))
    elif CS.out.cruiseState.standstill:
      can_sends.append(create_wheel_buttons(self.packer, CS.button_counter + 1, 0, cancel=False, acc_resume = True))
      can_sends.append(create_wheel_buttons(self.packer, CS.button_counter + 1, 2, cancel=False, acc_resume = True))

And this is chryslercan

  def create_wheel_buttons(packer, frame, bus, cancel = False, acc_resume = False):

    values = {
     "ACC_Cancel": cancel,
     "COUNTER": frame % 0x10,
     "ACC_Resume": acc_resume,
    }
    return packer.make_can_msg("Cruise_Control_Buttons", bus, values)

@adeebshihadeh adeebshihadeh changed the title Chyrlser: resume spam Chyrlser: resume ACC from standstill Jun 17, 2022
@adeebshihadeh adeebshihadeh linked a pull request Jul 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants