Skip to content

Commit fd93b57

Browse files
committed
always log leads, we hide them in ui
only spam resume when future is > vEgoStarting do rest but vw vw remove comments rename to resume maintain original button msg rate mazda: ensure no resume if cancelling Bump laika (#24920) test_models: check cruiseState.available (#24924) * check available is true if enabled is true * remove extra line bump laika ui: metric wider set speed box (#24890) Revert "VW FPv2: reduce number of ECU queries (#24706)" This reverts commit 6c02e55. ui: draw MAX above set speed (#24930) replay: handle missing socket while replaying route log with --allow flag (#24933) * fix: fix the problem with replay routes locally * fix: Exception with --allow flag in replay.cc Co-authored-by: Anton Rudomaneko <anton.rudomanenko@nami.ru> car_bug_report.yml: fix labels same for non-HDA2 Merge remote-tracking branch 'upstream/master' into enable-planner Always run planner if not opLong Revert "Rocket league model (#24869)" (#24936) * Revert rocket league * revert ref commit * New model ref commit try 0.2 0.1 should be pretty safe jenkins: set successful boot flag Honda Longitudinal: fix HUD max distance setting (#24915) Fix max distance setting on display update refs update camerad gitignores compatibility docs: fixup steering torque star (#24940) * Ascent has good torque, hard code Toyota, print all unexpected torque star cars * update docs * Use subtests * hardcode CHR for now generate * Hard code Impreza * update refs ui: change alerts to Inter (#24937) * ui: change alerts to Inter * fix up test ui: change sidebar font to Inter (#24931) * change sidebar to inter * clean up metric color rect radius * fix text placement * simplify rect placement ui: change set speed, speed limit and current speed to Inter (#24932) * ui: change set speed/speed limit to Inter * switch current speed to Inter remove Open Sans fonts from assets (#24946) DM: track RHD predictions (#24947) * driverview * auto choose * useless * remove * modeld not use toggle * remove from params * Revert "remove from params" This reverts commit a08df0b. * Revert "modeld not use toggle" This reverts commit 2730bf8. * Revert "remove" This reverts commit 21f7cfa. * Revert "driverview" This reverts commit 222d129. * semi revert Chrysler: fill cruiseState.available (#24907) * Update some signals to unified names and definitions Co-authored-by: Jonathan <jraycec@gmail.com> * steering looks good * Fix cp signals * Do steering signal changes separately * bump opendbc to master * fix fix * check available is true if enabled is true * fix * already added * bump opendbc, better cruise status names * bump opendbc * bump opendbc to master * bump panda Co-authored-by: Jonathan <jraycec@gmail.com> CANParser: invalid until valid (#24945) * CANParser: invalid until valid * bump opendbc * bump opendbc * fix counter in sim Refactor torque stuff (#24921) * Refactor torque stuff * Add to release * Add substitute and override * Maxlataccel is required * Add to asserts * add ideal car * Need china too * yamls already linted * Fixed some bugs * Fixup * Unreliable data * Add cehck * Better comment * ref commit update Cleanup car interfaces (#24948) * remove interface overrides * Fix test * set torque tune for ev6 Merge remote-tracking branch 'upstream/master' into enable-planner EV6: adjust steering thresholds (#24901) * EV6: adjust steering thresholds * Is there any friction * bump panda * no friction Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com> count_events improvements Navd added to README (#24953) (#24954) * Navd added to README * Update README.md Co-authored-by: Willem Melching <willem.melching@gmail.com> use correct tty device for serial Laikad: minor refactor (#24956) extract code to get_est_pos func VW MQB: Add FW for 2016 Volkswagen Passat (#24957) * VW MQB: Add FW for 2016 Passat B8 Passat B8 TDi 2.0 240HP DSG 7 Europe * mechanical sort Co-authored-by: Pierre Christen <netadvanced@gmail.com> cleanup torque tuning config (#24951) fix carla test fake driverState (#24959) use driverstatev2 Speed up YAML parsing with CSafeLoader (#24958) Use CSafeLoader can replay: get logs in parallel (#24960) * get can replay segs in parallel * total not needed Hyundai: remove bad esp fingerprint (#24952) Remove unknown "esp" fp add test for resuming fix test logger.cc: remove unused function append_property (#24966) remove append_property loggerd: remove rotate_lock (#24969) remove lock FfmpegEncoder: free codec_ctx in encoder_close (#24967) free context Log SOM power draw (#24975) * log SOM power draw * bump cereal Co-authored-by: Comma Device <device@comma.ai> Co-authored-by: Willem Melching <willem.melching@gmail.com> calibrationd: start faster by not waiting for carParams (#24976) * calibrationd: start faster by not waiting for carParams * fix process replay * update ref snapshot: fix rgb overflow (#24963) clamp rgb ui: use current calibration to center vanishing point (#24955) * compute x and y offsets using calibration * fix default calibration * clamp to max values * only use when valid * not while calibrating * less diff * cleanup zoom split locationd and liblocationd tests (#24977) * laikad: use cython version of gnss kf * fix import error * test liblocationd separate * Revert "laikad: use cython version of gnss kf" This reverts commit bdd769b. 2022 RAV4 XLE engine FW (#24973) Update values.py Added ecu.engine address for 2022 RAV4 XLE (ICE) bought in Edmonton, Canada Torque control: higher low speed gains and better steering angle deadzone logic (#24980) * Try no friction and no deadzone * Learn fromd ata * update refs onroad UI: fix onroad double tap (#24982) * The default implementation calls mousePressEvent(). * no sidebar when entering body * wrong one * you can't double tap with body anyway (fixes inconsistencies with prime vs not prime) * hide sidebar Power Monitoring test: fix exceptions (#24981) * fix missing POWER_DRAW * think should be 0 Update rednose: use EKF_sym_pyx (#24978) * Update rednose * Update rednose * cleanup bump rednose add laikad to process replay (#24889) * merge * Fix closing process executor after fetching orbits * cleanup * Add ref commit and revert test_processes hack * Fix * Fix ref * Fix test * Temp * Temp * Trying * Trying * Cleanup and change test * add ref commit * remove print * fix test getting stuck * cleanup fetch_orbits Co-authored-by: Gijs Koning <gijs-koning@live.nl> laikad: use cython filter (#24983) use cython filter ui: disable sync with model until more stable (#24984) move replay from selfdrive/ui/replay to tools/replay (#24971) * mv to tools/replay * change folder * add .gitignore * fix build doc * disable warning * enable warning after build * build qt/util.cc qt/api.cc to library * cleanup Properly pass KF dependencies to rednose (#24985) * Fix rednose dependencies * bump rednose * bump rednose build.py: remove retry logic (#24986) Chrysler: fix steering angle signals (#24926) * Chrysler_Update * only steering * revert other changes for now only steering * bump * Update ref_commit * bump opendbc * update refs Co-authored-by: Jonathan <jraycec@gmail.com> Toyota: Add missing 2021 RAV4 TSS2 esp FW (#24989) Add missing Canadian TRD 2021 RAV4 framereader.cc: remove nv12toyuv_buffer (#24991) remove nv12toyuv_buffer bump cereal don't log LaikadEphemeris in initData UI: wrap all text for translation (#24961) * rough multiple language demo * more wrappings * stash * add some bad translations * updates * map from french to spanish still has same problem of needing to call setText on everything * add files * restart UI * use return code * relative path * more translations * don't loop restart * Toggle and prime translations * try on device * try QComboBox with readable style * stash * not yet scrollable * stash * dynamic translations (doesn't work for dynamic widget strings yet) * clean up multiple option selector * store languages in json * try transparent * Try transparent popup * see how this looks * tweaks * clean up * clean up * clean up 2 and missing tr * wrap more strings * missing updater * fixes * add basic test to ensure all strings wrapped * try in CI * clean up * test name * fix test * always install qt dev tools * fix deps * fast test * add section so it prints multiple errors * debug * debug get rid of those * make any difference? * comment * oh... * run with offscreen platform * try out section * clean up * fix missing wrappings (it works!) * move down * space * clear relevant params, set TICI=1 Merge remote-tracking branch 'upstream/master' into enable-planner stricter test, speeds[-1] is 0.14 when starting here Honda Civic 2022: remove LKAS fault reinitialization (#24979) * no lkas problem * remove frame docs: ssh.comma.ai (#25000) Multilang: remove redundant QString() around tr() (#25003) remove qstring ui: replace line_vertices_data with QPolygonF (#25001) use QPolygonF use push_front remove selfdrive/common (#24997) swaglog.cc/cloudlog_common: pass json object by reference (#24996) * pass json object by reference * space between functions Multilang prerequisites (#24999) * some supporting code for multilang * for now just english * test for missing language files * test for checking if ts file is up to date * Skip test if causes exception, other test catches this Test test Should also work should now fail revert rmn * add to files_common * fix files_common * newlines * no need to not update * comment * only english * double quotes * switch around Camerad: small cleanup (#24992) * remove CameraExpInfo * remove release callback camerad: reduce cpu usage (#24993) wait for 50ms test onroad: lower camerad cpu usage cameraview.cc: prev_frame_id static -> class member cameraview.cc: qInfo -> qDebug Add laikadOffline subtest to process replay. (#24995) * Add subtests to process replay. Adds laikadOffline subtest * Update cpp. * Update ref * Update ref again * Update ref again * update ref * Fix disabling fetching orbits * Add proc name to event exception * update ref * Update setup_env * Fix offline test and update refs Merge remote-tracking branch 'upstream/master' into enable-planner no walrus Full localizer: Use standard naming conventions (#25007) Use standard naming conventions Toyota: fix BSM detection (#24964) * revert to 1 second * Revert "revert to 1 second" This reverts commit 6ab3f75. * Revert "remove toyota can fingerprinting exceptions (#22803)" This reverts commit d8f5e8b. fix static analysis * Revert "Revert "remove toyota can fingerprinting exceptions (#22803)"" This reverts commit fc359fc. * 1 second for all brands * update refs Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> tools: add support for nv12 in compressed_vipc (#24962) reshape for nv12 GM: Lower LKA loopback CAN Error timing threshold to accommodate dropped packets (#24927) * LKA loopback timing to 10Hz * Typo Co-authored-by: Willem Melching <willem.melching@gmail.com> Co-authored-by: Willem Melching <willem.melching@gmail.com> remove mypy ignore from a few scripts GM: prep and cleanup for future ports (#24910) * Interface radarOffCan set, comments * pass pcmCruise value to common events * add transType and networkLoc to iface * carstate use transtype to detect EV * ctrl: limit sends by config * Add clarifying comments for new vals * clean up * comment on new line * these have the same frequency * remove 25hz * add to upper comment * update refs * update refs * move into same block move into same block Co-authored-by: Shane Smiskol <shane@smiskol.com> update release notes Clean up CarControllers (#25008) * do VW * Do the rest * unused * ford cc formatting * final clean ups * also just return update output Chrysler: carState signals update (#24760) * carstate update * update refs Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> Chrysler Pacifica 2019 is supported (#25010) 19 is secretly supported Chrysler: add missing 2022 Pacifica Hybrid fingerprint (#24685) * Added 2022 PacHy info Didn't really need to add this but thought it would be useful. * Added 2022 PacHy info * Added 2022 PacHy info Added 2022 PacHy FP * add to current platform * generate docs * should only need this Co-authored-by: Shane Smiskol <shane@smiskol.com> Mazda: add missing FW version for CX-5 2022 (#24925) laikad: Improve logging, fix warning and more exception handling (#25005) * change logs and add some debugging. Add test * Less logging and better check for exceptions when parsing orbits * Fix debug log and fix kf initialization bump laika process replay: Fix setting environment vars (#25015) Fix setting environments in process replay Laikad: dont log when filter is not initialized enable laikad (#25013) * enable laikad * increase logprint for onroad test Laikad: Allow fetching orbits every minute (#25016) * Allow fetching orbits every minute * Small cleanup GM: values.py cleanup & minor updates (#24908) * Comment update on static limits * Astra FP cleanup * DBC autogen & customizable * Add new Escalade FP, disable bad * Add DROPPED CanBus value * Update/cleanup CarInfo * DBC -> defaultdict * Fix DBC typing issue * Revert Escalade fix * clean up * comment spacing * revert this for now Co-authored-by: Shane Smiskol <shane@smiskol.com> Merge remote-tracking branch 'upstream/master' into enable-planner2 only planner changes remove this test remove this test Update selfdrive/controls/lib/longitudinal_planner.py
1 parent bd782c9 commit fd93b57

File tree

177 files changed

+1761
-1125
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

177 files changed

+1761
-1125
lines changed

.github/ISSUE_TEMPLATE/car_bug_report.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Car bug report
22
description: For issues with a particular car make or model
3-
labels: ["car bug"]
3+
labels: ["car", "bug"]
44
body:
55

66
- type: markdown

.github/workflows/selfdrive_tests.yaml

+6-2
Original file line numberDiff line numberDiff line change
@@ -299,17 +299,21 @@ jobs:
299299
$UNIT_TEST selfdrive/loggerd && \
300300
$UNIT_TEST selfdrive/car && \
301301
$UNIT_TEST selfdrive/locationd && \
302+
selfdrive/locationd/test/_test_locationd_lib.py && \
302303
$UNIT_TEST selfdrive/athena && \
303304
$UNIT_TEST selfdrive/thermald && \
304305
$UNIT_TEST selfdrive/hardware/tici && \
305306
$UNIT_TEST selfdrive/modeld && \
306307
$UNIT_TEST tools/lib/tests && \
308+
./selfdrive/ui/tests/create_test_translations.sh && \
309+
QT_QPA_PLATFORM=offscreen ./selfdrive/ui/tests/test_translations && \
310+
./selfdrive/ui/tests/test_translations.py && \
307311
./common/tests/test_util && \
308312
./common/tests/test_swaglog && \
309313
./selfdrive/boardd/tests/test_boardd_usbprotocol && \
310314
./selfdrive/loggerd/tests/test_logger &&\
311315
./system/proclogd/tests/test_proclog && \
312-
./selfdrive/ui/replay/tests/test_replay && \
316+
./tools/replay/tests/test_replay && \
313317
./system/camerad/test/ae_gray_test && \
314318
coverage xml"
315319
- name: "Upload coverage to Codecov"
@@ -364,7 +368,7 @@ jobs:
364368
CI=1 AZURE_TOKEN='$AZURE_TOKEN' python selfdrive/test/process_replay/test_processes.py -j$(nproc) --upload-only"
365369
- name: "Upload coverage to Codecov"
366370
uses: codecov/codecov-action@v2
367-
371+
368372
model_replay_onnx:
369373
name: model replay onnx
370374
runs-on: ubuntu-20.04

.gitignore

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ selfdrive/loggerd/loggerd
4949
selfdrive/loggerd/bootlog
5050
selfdrive/sensord/_gpsd
5151
selfdrive/sensord/_sensord
52-
selfdrive/camerad/camerad
53-
selfdrive/camerad/test/ae_gray_test
52+
system/camerad/camerad
53+
system/camerad/test/ae_gray_test
5454
selfdrive/modeld/_modeld
5555
selfdrive/modeld/_dmonitoringmodeld
5656
/src/

.pre-commit-config.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ repos:
2020
hooks:
2121
- id: mypy
2222
exclude: '^(pyextra/)|(cereal/)|(rednose/)|(panda/)|(laika/)|(opendbc/)|(laika_repo/)|(rednose_repo/)/'
23-
additional_dependencies: ['lxml', 'numpy', 'types-atomicwrites', 'types-pycurl', 'types-requests', 'types-certifi']
23+
additional_dependencies: ['types-PyYAML', 'lxml', 'numpy', 'types-atomicwrites', 'types-pycurl', 'types-requests', 'types-certifi']
2424
args:
2525
- --warn-redundant-casts
2626
- --warn-return-any

README.md

+1
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ Directory Structure
121121
├── modeld # Driving and monitoring model runners
122122
├── proclogd # Logs information from proc
123123
├── sensord # IMU interface code
124+
├── navd # Turn-by-turn navigation
124125
├── test # Unit tests, system tests, and a car simulator
125126
└── ui # The UI
126127

RELEASES.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
Version 0.8.15 (2022-XX-XX)
1+
Version 0.8.15 (2022-07-XX)
22
========================
3-
* New driving model
43
* New lateral controller based on physical wheel torque model
54
* Much smoother control, consistent across the speed range
65
* Effective feedforward that uses road roll
@@ -10,8 +9,12 @@ Version 0.8.15 (2022-XX-XX)
109
* takes a larger input frame
1110
* outputs a driver state for both driver and passenger
1211
* automatically determines which side the driver is on (soon)
13-
* Display speed limit while navigating
1412
* Reduced power usage: device runs cooler and fan spins less
13+
* Minor UI updates
14+
* New font
15+
* Refreshed max speed design
16+
* Speed limits shown while navigating
17+
* More consistent camera view perspective across cars
1518
* AGNOS 5
1619
* Honda Civic 2022 support
1720
* Hyundai Tucson 2021 support thanks to bluesforte!

SConstruct

+15-8
Original file line numberDiff line numberDiff line change
@@ -356,22 +356,27 @@ Export('cereal', 'messaging', 'visionipc')
356356

357357
# Build rednose library and ekf models
358358

359+
rednose_deps = [
360+
"#selfdrive/locationd/models/constants.py",
361+
"#selfdrive/locationd/models/gnss_helpers.py",
362+
]
363+
359364
rednose_config = {
360365
'generated_folder': '#selfdrive/locationd/models/generated',
361366
'to_build': {
362-
'gnss': ('#selfdrive/locationd/models/gnss_kf.py', True, []),
363-
'live': ('#selfdrive/locationd/models/live_kf.py', True, ['live_kf_constants.h']),
364-
'car': ('#selfdrive/locationd/models/car_kf.py', True, []),
367+
'gnss': ('#selfdrive/locationd/models/gnss_kf.py', True, [], rednose_deps),
368+
'live': ('#selfdrive/locationd/models/live_kf.py', True, ['live_kf_constants.h'], rednose_deps),
369+
'car': ('#selfdrive/locationd/models/car_kf.py', True, [], rednose_deps),
365370
},
366371
}
367372

368373
if arch != "larch64":
369374
rednose_config['to_build'].update({
370-
'loc_4': ('#selfdrive/locationd/models/loc_kf.py', True, []),
371-
'pos_computer_4': ('#rednose/helpers/lst_sq_computer.py', False, []),
372-
'pos_computer_5': ('#rednose/helpers/lst_sq_computer.py', False, []),
373-
'feature_handler_5': ('#rednose/helpers/feature_handler.py', False, []),
374-
'lane': ('#xx/pipeline/lib/ekf/lane_kf.py', True, []),
375+
'loc_4': ('#selfdrive/locationd/models/loc_kf.py', True, [], rednose_deps),
376+
'pos_computer_4': ('#rednose/helpers/lst_sq_computer.py', False, [], []),
377+
'pos_computer_5': ('#rednose/helpers/lst_sq_computer.py', False, [], []),
378+
'feature_handler_5': ('#rednose/helpers/feature_handler.py', False, [], []),
379+
'lane': ('#xx/pipeline/lib/ekf/lane_kf.py', True, [], rednose_deps),
375380
})
376381

377382
Export('rednose_config')
@@ -411,6 +416,8 @@ SConscript(['selfdrive/locationd/SConscript'])
411416
SConscript(['selfdrive/sensord/SConscript'])
412417
SConscript(['selfdrive/ui/SConscript'])
413418

419+
SConscript(['tools/replay/SConscript'])
420+
414421
if GetOption('test'):
415422
SConscript('panda/tests/safety/SConscript')
416423

cereal

common/params.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ std::unordered_map<std::string, uint32_t> keys = {
128128
{"IsTakingSnapshot", CLEAR_ON_MANAGER_START},
129129
{"IsUpdateAvailable", CLEAR_ON_MANAGER_START},
130130
{"JoystickDebugMode", CLEAR_ON_MANAGER_START | CLEAR_ON_IGNITION_OFF},
131-
{"LaikadEphemeris", PERSISTENT},
131+
{"LaikadEphemeris", PERSISTENT | DONT_LOG},
132132
{"LastAthenaPingTime", CLEAR_ON_MANAGER_START},
133133
{"LastGPSPosition", PERSISTENT},
134134
{"LastManagerExitReason", CLEAR_ON_MANAGER_START},

common/swaglog.cc

+2-1
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,9 @@ static void log(int levelnum, const char* filename, int lineno, const char* func
6666
char levelnum_c = levelnum;
6767
zmq_send(s.sock, (levelnum_c + log_s).c_str(), log_s.length() + 1, ZMQ_NOBLOCK);
6868
}
69+
6970
static void cloudlog_common(int levelnum, const char* filename, int lineno, const char* func,
70-
char* msg_buf, json11::Json::object msg_j={}) {
71+
char* msg_buf, const json11::Json::object &msg_j={}) {
7172
std::lock_guard lk(s.lock);
7273
if (!s.initialized) s.initialize();
7374

0 commit comments

Comments
 (0)