Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for matching panda rate limits #1352

Open
sshane opened this issue Feb 9, 2023 · 1 comment
Open

Unit test for matching panda rate limits #1352

sshane opened this issue Feb 9, 2023 · 1 comment
Labels
car related to opendbc/car/ CI / testing

Comments

@sshane
Copy link
Contributor

sshane commented Feb 9, 2023

When the user overrides, panda expects the down rate is at least as high as the rate limit, but up needs to be under the limit. Add a test like in panda, but add user overriding. Would have caught mismatch in commaai/openpilot#26934, or the panda PR that changed it, when bumped.

@sshane
Copy link
Contributor Author

sshane commented Aug 8, 2023

@adeebshihadeh do you think a good place for this is https://github.com/commaai/openpilot/blob/8d3e661f795260ebd708975105d98f1bdbbcf181/selfdrive/car/tests/test_models.py#L204 with fake actuators and driver torque?

Can start adding more cases like these for torque cars

@adeebshihadeh adeebshihadeh added the car related to opendbc/car/ label Aug 9, 2024
@adeebshihadeh adeebshihadeh transferred this issue from commaai/openpilot Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ CI / testing
Projects
None yet
Development

No branches or pull requests

2 participants