Rails 5.1 support #105
Merged
Rails 5.1 support #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitoball
requested changes
May 5, 2017
.travis.yml
Outdated
| - rbx-2 | ||
| - jruby | ||
| gemfile: | ||
| - gemfiles/active4.0.13.gemfile | ||
| - gemfiles/active4.1.16.gemfile | ||
| - gemfiles/active4.2.7.1.gemfile | ||
| - gemfiles/active5.0.0.1.gemfile | ||
| - gemfiles/active5.1.gemfile |
There was a problem hiding this comment.
Please name this file to active5.1.0.gemfile as other files.
.travis.yml
Outdated
| - gemfiles/rails4.0.13.gemfile | ||
| - gemfiles/rails4.1.16.gemfile | ||
| - gemfiles/rails4.2.7.1.gemfile | ||
| - gemfiles/rails5.0.0.1.gemfile | ||
| - gemfiles/rails5.1.gemfile |
gemfiles/active5.1.gemfile
Outdated
|
|
||
| gem "coveralls", :require => false | ||
| gem "rubocop", :require => false | ||
| gem "activesupport", "5.1" |
There was a problem hiding this comment.
Please specify tiny version like '5.1.0'
gemfiles/rails5.1.gemfile
Outdated
|
|
||
| gem "coveralls", :require => false | ||
| gem "rubocop", :require => false | ||
| gem "rails", "5.1" |
|
@eitoball thanks for the review, i'll fix the issues. On the failing build it's complaining about outdated gemfile.lock. I assume some version of gem in lockfile was revoked from rubygems.org.
i haven't touched those lockfiles trying to remove the |
mfazekas
force-pushed
the
rails-51
branch
6 times, most recently
from
fa6ceee to
e5746dd
Compare
|
@eitoball pls review |
eitoball
approved these changes
May 5, 2017
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5.1 support + added ruby 2.4 and removed ruby 2.0 from travis