Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Session Expired Warning/Error Dialog to mixed in of CoMPAS OpenSCD #170

Closed
dlabordus opened this issue Jul 18, 2022 · 0 comments · Fixed by #196
Closed

Convert Session Expired Warning/Error Dialog to mixed in of CoMPAS OpenSCD #170

dlabordus opened this issue Jul 18, 2022 · 0 comments · Fixed by #196
Assignees

Comments

@dlabordus
Copy link

dlabordus commented Jul 18, 2022

Describe the bug
When a session is about to expire or is expired two dialogs are displayed. These are now added by a change in the OpenSCD Element, it would be nice to create a mixed-in for this and add this mixed-in to the OpenSCD Element.
If the new OpenSCD Core is avaliable and CoMPAS OpenSCD isn't a fork anymore this will making a switch to the new core easier.
Also included functionality to load the User Information and NSDoc Files in this mixed-in. These two are now sneaky loaded when the CoMPAS Settings Plugin is loaded.

Expected behavior
Create a CoMPAS mixed-in to add the dialogs to the application and add this mixed-in to the OpenSCD Element.
Remove the logic to add the dialogs from the OpenSCD Render function.
Also put logic for loading the User Info and NSDoc Files from the CoMPAS Backend service to this mixed-in.

@dlabordus dlabordus changed the title Convert Parts of the Session Expired Warning/Error Dialog to mixed in of CoMPAS OpenSCD Convert Session Expired Warning/Error Dialog to mixed in of CoMPAS OpenSCD Jul 18, 2022
@dlabordus dlabordus self-assigned this Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant