Why is SVD not converging? #10
Replies: 4 comments
-
Hi @mexicantexan, Would it be possible to get the values of the test matrix that is fed to the Cheers, Thomas |
Beta Was this translation helpful? Give feedback.
-
Of course @KelSolaar ! Here is the 24x3 array of values that are coming out of the section of test code y'all shared for the X-Rite 24 patch: [[ 9.97202281e-02 3.85103423e-02 1.97636268e-02] for reference here is the snippet of code that gathers the array above before comparing it to the reference values:
|
Beta Was this translation helpful? Give feedback.
-
Oh and here is the test image I am using: |
Beta Was this translation helpful? Give feedback.
-
Sorry for not coming back to you earlier, it is quite surprising that the fitting fails, the colour looks fine here: I managed to fit it against this test data: https://github.com/colour-science/colour/blob/develop/colour/characterisation/correction.py#L785 array([[ 0.74237056, -0.00493562, 0.17259327],
[ 0.17577396, 0.56242156, 0.19284019],
[ 0.04939617, 0.01500463, 1.03979242]]) |
Beta Was this translation helpful? Give feedback.
-
I was having trouble getting the SVD to converge while using the colour_correction_matrix_Cheung2004 function with the default 3 terms. Ended up figuring out that the array M_T had ??too small of numbers in it?? My current workaround is to multiply both M_T and M_R by an order of magnitude, which allows the SVD to converge.
The results seem to be correct, didn't know if this was bad practice?
Beta Was this translation helpful? Give feedback.
All reactions