-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy builds are not included in NPM package. #232
Comments
Ugh, I'm an idiot. 🤦🏽♀️ Yes, I released without running |
(Not closed until I release a patch version lol) |
@jgerigmeyer Are you aware of any convention for what that version number would be? We currently use the "patch" version number for releases with actual features, since we're still in 0.x.y, so it would need to be a |
@LeaVerou Oh, that's a great question! I don't feel strongly, but my general approach is that during pre-1.0 I treat "patch" and "feature" the same, so I would lean toward |
This seems to be fixed for me in One downside of using |
Ah, I didn't know that. Even more reason to implement alpha blending and release it in 0.4.2! |
New legacy builds were added in #215 to support older versions of Node etc, but it appears that the legacy built files are missing in the published NPM package for v0.4.1: https://unpkg.com/browse/colorjs.io@0.4.1/dist/
I'm not sure what the build/release process is for colorjs.io, but when I
npm pack
locally the files are included correctly -- perhapsnpm run build
wasn't run before the new release? In case that's the issue, I'll open a PR to address that with aprepack
script.The text was updated successfully, but these errors were encountered: