-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new list please! #1731
Comments
precision: screenshot |
Your list is not valid. I don't believe providing any response will be faster than just aborting network request. You need to read more about pre-parsing directives -
|
OK, but take a look at the screenshot and explain why it works.
Test and tell me if it doesn't. |
These are the only valid directive values in uBo: https://github.com/gorhill/uBlock/blob/bc7f1492522f08477325242d95f4fd3992bf5d42/src/js/storage.js#L907 These are some, probably all, valid directive values in adguard: https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#what-constants-we-declare The redirect-rule is not to speed up the browser. It is used for fixing breakages, anti-adblock, and making list writing easier. |
Because unknown directives are ignored. All filters are parsed.
So, your filter is only for AdGuard? uBO does not support most of the logic. These are pre-parsing directives, even if "logic" works they will not be dynamically updated based on request type, because they are "executed" only when list is loaded (downloaded/updated).
This is your list. You need to prove it's useful.
To fix anti-adblockers which expect some content to be returned in response. |
To quote the wiki -- Standalone redirect directives are useful when the blocking of a resource is optional but we still want the resource to be redirected should it ever be blocked by whatever mean - whether through a separate block filter, a dynamic filtering rule, etc. |
Claims like this needs to be substantiated with evidences and in a way that everybody can reproduce. |
@K-mikaZ after all - thank you! Thanks to your list we learned that 😄 |
I have create a list that boost page loading by automatically creating redirect rules based on gorhill's redirect-rule (which are often omitted but important) for all present and futur filters/lists.
You can find it here: Noop-My-Filters-Please (the RAW version)
You can test it before, of course.
The text was updated successfully, but these errors were encountered: