Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new list please! #1731

Closed
K-mikaZ opened this issue Jun 30, 2020 · 8 comments
Closed

Add new list please! #1731

K-mikaZ opened this issue Jun 30, 2020 · 8 comments
Labels
directory-data changes to basic FilterLists data

Comments

@K-mikaZ
Copy link

K-mikaZ commented Jun 30, 2020

I have create a list that boost page loading by automatically creating redirect rules based on gorhill's redirect-rule (which are often omitted but important) for all present and futur filters/lists.

You can find it here: Noop-My-Filters-Please (the RAW version)

You can test it before, of course.

@collinbarrett collinbarrett added the directory-data changes to basic FilterLists data label Jun 30, 2020
@K-mikaZ
Copy link
Author

K-mikaZ commented Jun 30, 2020

precision:
Only for ublock and nano adblocker
It's not really a block list, it only applies the appropriate redirects to each filter that has omitted to specify it.
e.g:
the filter ||theBlockedSite.tld
become:
||theBlockedSite.tld$script,redirect-rule=noopjs if it is a script concern,
||theBlockedSite.tld$xhr,redirect-rule=nooptext if it is a xhr concern...

screenshot
Imgur

@K-mikaZ K-mikaZ closed this as completed Jun 30, 2020
@K-mikaZ K-mikaZ reopened this Jun 30, 2020
@gwarser
Copy link
Contributor

gwarser commented Jun 30, 2020

Your list is not valid.

I don't believe providing any response will be faster than just aborting network request.

You need to read more about pre-parsing directives - !#if. For example only these tokens are supported:

ext_ublock
env_chromium
env_edge
env_firefox
env_mobile
env_safari
false
cap_html_filtering
cap_user_stylesheet

@K-mikaZ
Copy link
Author

K-mikaZ commented Jun 30, 2020

Your list is not valid.
You need to read more about pre-parsing directives - !#if. For example only these tokens are supported:

OK, but take a look at the screenshot and explain why it works.
And the link that you give me (and for information that I have already read) points to AdguardTeam/AdguardBrowserExtension#917 which explains:

Conditions:
...
Condition supports all the basic logical operators.

I don't believe providing any response will be faster than just aborting network request.

Test and tell me if it doesn't.
And please, explain to me why gorhill would create a redirect-rule if it was useless?

@liamengland1
Copy link
Contributor

liamengland1 commented Jun 30, 2020

These are the only valid directive values in uBo: https://github.com/gorhill/uBlock/blob/bc7f1492522f08477325242d95f4fd3992bf5d42/src/js/storage.js#L907

These are some, probably all, valid directive values in adguard: https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#what-constants-we-declare

The redirect-rule is not to speed up the browser. It is used for fixing breakages, anti-adblock, and making list writing easier.

@gwarser
Copy link
Contributor

gwarser commented Jun 30, 2020

OK, but take a look at the screenshot and explain why it works.

Because unknown directives are ignored. All filters are parsed.

And the link that you give me (and for information that I have already read) points to AdguardTeam/AdguardBrowserExtension#917 which explains:

So, your filter is only for AdGuard? uBO does not support most of the logic. These are pre-parsing directives, even if "logic" works they will not be dynamically updated based on request type, because they are "executed" only when list is loaded (downloaded/updated).

Test and tell me if it doesn't.

This is your list. You need to prove it's useful.

And please, explain to me why gorhill would create a redirect-rule if it was useless?

To fix anti-adblockers which expect some content to be returned in response.

@K-mikaZ K-mikaZ closed this as completed Jun 30, 2020
@uBlock-user
Copy link

uBlock-user commented Jun 30, 2020

And please, explain to me why gorhill would create a redirect-rule if it was useless?

redirect-rule provides ease for redirecting already existing blocking filters with responses and only creates 1 filter instead of 2(as seen by using $redirect)

To quote the wiki -- Standalone redirect directives are useful when the blocking of a resource is optional but we still want the resource to be redirected should it ever be blocked by whatever mean - whether through a separate block filter, a dynamic filtering rule, etc.

@gorhill
Copy link

gorhill commented Jun 30, 2020

boost page loading by automatically creating redirect rules

Claims like this needs to be substantiated with evidences and in a way that everybody can reproduce.

@gwarser
Copy link
Contributor

gwarser commented Jul 8, 2020

@K-mikaZ after all - thank you! Thanks to your list we learned that ping, beacon, and websocket redirecion is pointless/invalid and redirecting to empty creates redirection regardless of type. Besides that, snapshot of your list will be used to test pre-parsing directives.

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory-data changes to basic FilterLists data
Projects
None yet
Development

No branches or pull requests

6 participants