Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to disable the 'All' option for filtering #137

Open
JeffersonBledsoe opened this issue Aug 31, 2021 · 0 comments · May be fixed by #138
Open

No way to disable the 'All' option for filtering #137

JeffersonBledsoe opened this issue Aug 31, 2021 · 0 comments · May be fixed by #138

Comments

@JeffersonBledsoe
Copy link
Member

JeffersonBledsoe commented Aug 31, 2021

Currently, the All filter option is hard-coded to always be included. It would be nice if there were an option to enable/ disable this option for collection filters. This should be usable with all of the input_type options.

Issues

How should the filter behave if we remove the all option?

  • Default to what would be the first filter option

  • Provide an option to define what the default

    • We would have to check the catalog for all the available options when setting up the portlet
    • We still wouldn't be able to filter without the event subscriber triggering for the initial page visit
@JeffersonBledsoe JeffersonBledsoe linked a pull request Sep 6, 2021 that will close this issue
@JeffersonBledsoe JeffersonBledsoe self-assigned this Sep 21, 2021
@JeffersonBledsoe JeffersonBledsoe removed their assignment Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant