-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CldOgImage component #60
feat: Add CldOgImage component #60
Conversation
@kcoderhtml is attempting to deploy a commit to the Cloudinary DevX Team on Vercel. A member of the Team first needs to authorize it. |
I'm holding off on the documentation for now until I'm sure this is how this should be implemented |
I took the route of requiring the |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hey @kcoderhtml this seems to look good to me! want to create some basic documentation around it? you could largely copy a lot from Next Cloudinary if you'd like, it will also help ensure that its working properly |
happy to! where should those docs go? |
oh wait nvm; i got confused when I loaded the docs site lol |
I added a configuration page and a basic usage page with an example of simple usage and then more complex usage using the AI API and transformations. I mainly just redirect the user to take a look at the CldImage component as the same options apply, and it seems silly to basically completely duplicate an existing page. |
If you want me to add the rest of the options I can though! |
hey @kcoderhtml i pushed a change that uses the new component in the head of hte documentation to dogfood it. it seems to work. once it's merged, if you have time, would be great if you wouldn't mind spot checking the production website to help me double check thanks for your contribution. this PR is eligible for free Cloudinary Hackatoberfest swag. Please send me an email at hacktoberfest@cloudinary.com with your name, GitHub username, and a link to the PR where I'll send further instructions. Happy Hacktoberfest! |
@all-contributors please add @kcoderhtml for code |
I've put up a pull request to add @kcoderhtml! 🎉 |
# [1.2.0](v1.1.2...v1.2.0) (2024-11-01) ### Features * Add CldOgImage component ([#60](#60)) ([7255ac2](7255ac2))
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
i'll check it right now! thanks for the swag :) I got some last year and have been wearing my tshirt super often lol |
Tested and it seems to be working great! I don't notice anything weird. |
awesome thank you!! |
Description
Added the
CldOgImage
component inastro-cloudinary/src/components/
and exported it in the index.ts for the same directory.Issue Ticket Number
Fixes #23
Type of change
Checklist