getProductTrades returns undefined

[radiantone]

Hi,
Looks as though this is not returning results.

const Gdax = require('gdax');
const publicClient = new Gdax.PublicClient();
publicClient.getProductTrades('BTC-USD', function(trades) {
console.log(trades);
});

[rmm5t]

You're using the callback signature. Like every callback in node, the first argument is always the error. The current GDAX callback signature passes 3 arguments to the callback function (err, response, and data). You're incorrectly assuming that only data is passed, and because there's no error, you're merely logging the null error argument.

Your code should instead read:

publicClient.getProductTrades('BTC-USD', function(err, response, trades) {
  console.log(trades);
});

// OR, more idiomatically:
publicClient.getProductTrades('BTC-USD', (err, response, trades) => console.log(trades))

Alternatively, use the Promise signature:

publicClient.getProductTrades('BTC-USD').then(console.log);

---

For more information read:

• https://github.com/coinbase/gdax-node#using-callbacks
• https://github.com/coinbase/gdax-node#using-promises

---

Please close this issue.

[radiantone]

I appreciate that clarification. Thank you.