Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of 0.4.1 failed with weird error #11

Closed
jaraco opened this issue Aug 31, 2024 · 3 comments
Closed

Release of 0.4.1 failed with weird error #11

jaraco opened this issue Aug 31, 2024 · 3 comments

Comments

@jaraco
Copy link
Member

jaraco commented Aug 31, 2024

Release of 0.4.1 failed with the following error:

Successfully built coherent_cli-0.4.1.tar.gz and coherent_cli-0.4.1-py3-none-any.whl
creating virtual environment...
installing twine...
Uploading distributions to https://upload.pypi.org/legacy/
Uploading coherent_cli-0.4.1-py3-none-any.whl
25l
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/7.6 kB • --:-- • ?
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/7.6 kB • --:-- • ?
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 7.6/7.6 kB • 00:00 • ?
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 7.6/7.6 kB • 00:00 • ?
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 7.6/7.6 kB • 00:00 • ?
25hWARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         '=?utf-8?q?=22Bartosz_S=C5=82awecki=22_=3Cba...ki=40gmail=
         2Ecom=3E?=' is not a valid email address: An email address must have an
         @-sign. See https://packaging.python.org/specifications/core-metadata  
         for more information.                               

It seems the package metadata is corrupted.

When I do the build locally, I see:

Author-Email: "Jason R. Coombs" <ba...ki@gmail.com>

(note, I've elided part of the email with ... for privacy)

in the metadata. It seems we're bitten already by casperdcl/git-fame#96 (comment) (git-fame can't reliably generate author information).

I suspect, though, that different metadata is getting generated for the build in CI, because in CI, the Git depth is different, so the attribution data is different, and bswck is getting picked up as the author, and then something isn't handling the encoding of the non-ascii characters well, leading to the mangled "email".

@jaraco
Copy link
Member Author

jaraco commented Aug 31, 2024

Good news is, I can replicate the issue. If I build the project using a shallow clone (--depth 1), I see that exact string in the Author-Email of the generated wheel, meaning the encoding issue is on the coherent side and should be easy enough to fix, once isolated.

@jaraco
Copy link
Member Author

jaraco commented Aug 31, 2024

For now, I've uploaded the 0.4.1 release manually (even with that weird Author-Email), while we address these other issues.

@jaraco
Copy link
Member Author

jaraco commented Aug 31, 2024

I've filed separate issues discovered above, but since the release is now public, there's nothing more to do here.

@jaraco jaraco closed this as completed Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant