Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Morecantile as dependency? #283

Closed
vincentsarago opened this issue Oct 6, 2020 · 1 comment · Fixed by #285
Closed

Add Morecantile as dependency? #283

vincentsarago opened this issue Oct 6, 2020 · 1 comment · Fixed by #285
Labels

Comments

@vincentsarago
Copy link
Member

because @kylebarron loves mono-repo we could add morecantile as an optional dependency and archive rio-tiler-crs.

To make sure we keep compatibily, we will need to create an Object for mercantile that replicates morecantile methods.

This shouldn't be a breaking changes.

@vincentsarago
Copy link
Member Author

I've started the implementation over #285

The more I think about it the more I think it will be OK to switch to morecantile directly 😄

Pro

  • multiple TMS by default
  • make rio-tiler-crs useless

Cons

  • add a dependencies (morecantile needs pydantic)
  • morecantile rely on TMS document while mercantile rely on pure maths (could be a pro 🤷‍♂️)

let's count the 👍 👎 please

@vincentsarago vincentsarago changed the title Add Morecantile as an optional dependency? Add Morecantile as dependency? Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant