Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feedbacks are not shown in reason popup when there are too many feedbacks #554

Closed
MrOrz opened this issue Nov 21, 2023 · 7 comments · Fixed by #556, #581 or #583
Closed

New feedbacks are not shown in reason popup when there are too many feedbacks #554

MrOrz opened this issue Nov 21, 2023 · 7 comments · Fixed by #556, #581 or #583
Labels
bug good first issue help wanted

Comments

@MrOrz
Copy link
Member

MrOrz commented Nov 21, 2023 •
edited
Loading

New feedbacks to this reply https://dev.cofacts.tw/reply/aaluiHkB9w1KR1Ikury_ is never shown, because it has already more than 100 feedbacks.

Currently we only load 100 feedbacks in the reasons display:
https://github.com/cofacts/rumors-site/blob/53690ec8e817f02a1b743b6aa28a274b68b93a1a/components/ArticleReplyFeedbackControl/ReasonsDisplay.js#L49C14-L49C17

This causes new feedbacks are not shown in the "See more" dialog. We should remove the limit.
Also, we should consider hiding feedbacks with no reasons.
@MrOrz MrOrz changed the title Loads all feedback when reason display is shown New feedbacks are not shown in reason popup when there are too many feedbacks Nov 21, 2023
@marcussfu
Copy link
Contributor

I'll do it

@MrOrz MrOrz linked a pull request Jan 7, 2024 that will close this issue
adjust 'New feedbacks are not shown in reason popup when there are too many feedbacks' #556
Merged
@MrOrz
Copy link
Member Author

MrOrz commented Feb 29, 2024 •
edited
Loading

It seems that sorting is not working as expected.
Feedbacks with comments should come first, but still order by createdAt.

截圖 2024-02-29 下午8 17 29

@MrOrz MrOrz reopened this Feb 29, 2024
@belong112
Copy link
Contributor

PR preparing

@MrOrz MrOrz linked a pull request Nov 24, 2024 that will close this issue
fix: feedbacks aren't sorted as expected #581
Merged
@johnson-liang
Copy link
Contributor

johnson-liang commented Nov 25, 2024 •
edited
Loading

After deploying #581 to staging, it seems that comments with text goes to the bottom of the list, which is the opposite of what we want.

https://dev.cofacts.tw/reply/aaluiHkB9w1KR1Ikury_

圖片
圖片

@belong112 would you mind take a look?

@johnson-liang johnson-liang reopened this Nov 25, 2024
@belong112
Copy link
Contributor

belong112 commented Nov 25, 2024 •
edited
Loading

Ok, let me take a look, sorry for having the mistake

@belong112
Copy link
Contributor

I've sent a new PR, plz check

@MrOrz MrOrz linked a pull request Nov 25, 2024 that will close this issue
fix: feedbacks were not sorted correctly #583
Merged
@MrOrz
Copy link
Member Author

MrOrz commented Nov 25, 2024

Closed by #583 , kudos to @belong112 🎉

@MrOrz MrOrz closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
4 participants
@MrOrz @marcussfu @belong112 @johnson-liang