Fix class to show bookmarks colours

[CarolinaCobo]

✨ Codu Pull Request 💻

Fixes #(issue)

Pull Request details

• Bookmark and like icons weren't displaying the colours when clicked.

Any Breaking changes

None

Associated Screenshots

[vercel]

@CarolinaCobo is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The pull request includes modifications to the ArticleMenu and ArticlePreview components, primarily focusing on the styling of the HeartIcon and BookmarkIcon components. The order of the width and height classes for these icons has been switched. Additionally, the PopoverPanel className in ArticleMenu has been updated to conditionally render based on its open state. The clipboard interaction logic has been refined to prevent copying under certain conditions. Overall, the changes enhance the UI behavior and interaction logic without introducing new functionalities.

Changes

File	Change Summary
components/ArticleMenu/ArticleMenu.tsx	- Updated HeartIcon and BookmarkIcon className order from w-6 h-6 to h-6 w-6. - Adjusted PopoverPanel className to conditionally apply "hidden" based on isPopoverPanelOpen state. - Modified handleCopyToClipboard to prevent copying if button label does not match innerHTML.
components/ArticlePreview/ArticlePreview.tsx	- Updated BookmarkIcon className order from w-6 h-6 to h-6 w-6. - No changes to logic or functionality.

Possibly related PRs

• feat: Ensure the article appears exactly as it will when published #1102 #1153: The changes in the ArticlePreview component regarding the BookmarkIcon className are directly related to the modifications made in the ArticleMenu component, as both involve updates to the BookmarkIcon styling.
• Fix: Prevent article page from calling bookmarks for unauthenticated users (#1138) #1165: The updates in ArticlePreview.tsx concerning the management of bookmarks and user authentication are relevant to the changes in ArticleMenu.tsx, as both components deal with bookmark functionality and user interactions.

Suggested reviewers

• NiallJoeMaher
• John-Paul-Larkin

Poem

In the menu, icons gleam,
With heights and widths, they team.
A popover now shows with grace,
Clipboard checks keep pace.
Hopping through code, we cheer,
For UI changes, oh so dear! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

components/ArticleMenu/ArticleMenu.tsx (1)

Line range hint 52-69: Consider improving error handling for like/bookmark actions.

The error handling is currently limited to console logging. Consider adding user feedback for failed actions to improve the user experience.

Here's a suggested implementation:

 const likePost = async (postId: string, setLiked = true) => {
   if (likeStatus === "loading") return;
   try {
     await like({ postId, setLiked });
   } catch (err) {
-    // @TODO handle error
-    console.error(err);
+    console.error('Failed to like post:', err);
+    // Show user feedback
+    toast.error('Failed to like post. Please try again.');
   }
 };

 const bookmarkPost = async (postId: string, setBookmarked = true) => {
   if (bookmarkStatus === "loading") return;
   try {
     await bookmark({ postId, setBookmarked });
   } catch (err) {
-    // @TODO handle error
-    console.error(err);
+    console.error('Failed to bookmark post:', err);
+    // Show user feedback
+    toast.error('Failed to bookmark post. Please try again.');
   }
 };

Note: You'll need to import a toast notification library of your choice.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 051f633 and b7b6ff0.

📒 Files selected for processing (2)

• components/ArticleMenu/ArticleMenu.tsx (2 hunks)
• components/ArticlePreview/ArticlePreview.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• components/ArticlePreview/ArticlePreview.tsx

🔇 Additional comments (2)

components/ArticleMenu/ArticleMenu.tsx (2)

Line range hint 142-147: LGTM! HeartIcon styling is correct.

The conditional color styling properly shows red for liked state and neutral for unliked state, which aligns with the PR objective.

---

Line range hint 165-170: LGTM! BookmarkIcon styling is correct.

The conditional color styling properly shows blue for bookmarked state and neutral for unbookmarked state, which directly addresses the PR objective.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
codu	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 25, 2024 5:51pm

[NiallJoeMaher]

🌮 🦖