Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add items to list converted from paragraph #995

Closed
tiotdev opened this issue Dec 13, 2019 · 3 comments · Fixed by #1001
Closed

Cannot add items to list converted from paragraph #995

tiotdev opened this issue Dec 13, 2019 · 3 comments · Fixed by #1001
Assignees
Labels

Comments

@tiotdev
Copy link

tiotdev commented Dec 13, 2019

To reproduce:

  1. Write a paragraph
  2. Convert to list
  3. Press the return key to add a new item to the list - it does not work
@neSpecc neSpecc added the bug label Dec 16, 2019
@next-direction
Copy link

Just played around with this. First thing I recognized is that it doesn‘t matter what kind of conversion is done. Paragraph to heading also leads to non-working lists.

I think there is an event handler inside the flipper component which stops propagation of the keys that are registered in the component.

@next-direction
Copy link

After further investigating this issue, turns out there is a logic in src/components/modules/toolbar/inline.ts where the order should be the other way around:

this.Editor.Listeners.on(this.nodes.conversionToggler, 'click', () => {
  this.Editor.ConversionToolbar.toggle((conversionToolbarOpened) => {
    if (conversionToolbarOpened) {
      this.flipper.deactivate();
    } else {
      this.flipper.activate();
    }
  });
});

When convertion toolbar opens, it should activate, when it is closed, it should deactivate. Currently it is the exact opposite.

@neSpecc
Copy link
Member

neSpecc commented Mar 14, 2020

Resolved by #1001
Released in 2.17.0

Thanks to @aablinov and @khaydarov

@neSpecc neSpecc closed this as completed Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants