Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make nhooyr.io/websocket/internal/test/wstest public #214

Closed
zhangyoufu opened this issue Mar 15, 2020 · 2 comments
Closed

make nhooyr.io/websocket/internal/test/wstest public #214

zhangyoufu opened this issue Mar 15, 2020 · 2 comments

Comments

@zhangyoufu
Copy link

This package is useful for anyone writing WebSocket-related test cases. But it is an internal package, thus cannot be used outside nhooyr.io/websocket.

I think this package should be moved out of internal, like the relationship between net/http and net/http/httptest.
@zhangyoufu
Copy link
Author

duplicate of #197

@nhooyr
Copy link
Contributor

nhooyr commented Mar 15, 2020

Yea, definitely a very useful package, happy there's demand for it :) will def close out #197 sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhangyoufu @nhooyr